From b541b9ff94af8d0464deeb6e902dcc653b9c44b4 Mon Sep 17 00:00:00 2001 From: "Yann E. MORIN" Date: Sun, 17 Jul 2016 10:44:25 +0200 Subject: [PATCH] system: provide no default for custom skeleton path Being custom means that our default one is not suitable to start with. So there is no reason to offer it as the default path. Add a check that it is not empty. Add a separating empty line, for good measure, too. Signed-off-by: "Yann E. MORIN" Cc: Romain Naour Cc: Arnout Vandecappelle Reviewed-by: Romain Naour Signed-off-by: Thomas Petazzoni --- package/skeleton/skeleton.mk | 6 ++++++ system/Config.in | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/package/skeleton/skeleton.mk b/package/skeleton/skeleton.mk index 7a7c200f76..d580fcbfff 100644 --- a/package/skeleton/skeleton.mk +++ b/package/skeleton/skeleton.mk @@ -17,6 +17,12 @@ ifeq ($(BR2_ROOTFS_SKELETON_CUSTOM),y) SKELETON_PATH = $(call qstrip,$(BR2_ROOTFS_SKELETON_CUSTOM_PATH)) +ifeq ($(BR_BUILDING),y) +ifeq ($(SKELETON_PATH),) +$(error No path specified for the custom skeleton) +endif +endif + ifeq ($(BR2_ROOTFS_MERGED_USR),y) # Ensure the user has prepared a merged /usr. diff --git a/system/Config.in b/system/Config.in index b895db9014..6fce8e173e 100644 --- a/system/Config.in +++ b/system/Config.in @@ -184,9 +184,9 @@ config BR2_ROOTFS_SKELETON_CUSTOM endchoice if BR2_ROOTFS_SKELETON_CUSTOM + config BR2_ROOTFS_SKELETON_CUSTOM_PATH string "custom target skeleton path" - default "system/skeleton" help Path to custom target skeleton. -- 2.30.2