From b556ea3b4653c99c2c8b5ecce5565f1b4963078b Mon Sep 17 00:00:00 2001 From: Richard Biener Date: Tue, 24 May 2016 14:40:35 +0000 Subject: [PATCH] re PR tree-optimization/71240 (ICE on valid code at -O2 and above on x86_64-linux-gnu: verify_gimple failed) 2016-05-24 Richard Biener PR tree-optimization/71240 * tree-ssa-math-opts.c (init_symbolic_number): Verify the source has integral type. * gcc.dg/optimize-bswapsi-5.c: New testcase. From-SVN: r236644 --- gcc/ChangeLog | 6 +++++ gcc/testsuite/ChangeLog | 5 ++++ gcc/testsuite/gcc.dg/optimize-bswapsi-5.c | 31 +++++++++++++++++++++++ gcc/tree-ssa-math-opts.c | 3 +++ 4 files changed, 45 insertions(+) create mode 100644 gcc/testsuite/gcc.dg/optimize-bswapsi-5.c diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 13134d91114..45313abff88 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,9 @@ +2016-05-24 Richard Biener + + PR tree-optimization/71240 + * tree-ssa-math-opts.c (init_symbolic_number): Verify the source + has integral type. + 2016-05-24 Richard Biener PR tree-optimization/71230 diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index a6f65b87a19..25decd38093 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2016-05-24 Richard Biener + + PR tree-optimization/71240 + * gcc.dg/optimize-bswapsi-5.c: New testcase. + 2016-05-24 Richard Biener PR tree-optimization/71230 diff --git a/gcc/testsuite/gcc.dg/optimize-bswapsi-5.c b/gcc/testsuite/gcc.dg/optimize-bswapsi-5.c new file mode 100644 index 00000000000..a8245474696 --- /dev/null +++ b/gcc/testsuite/gcc.dg/optimize-bswapsi-5.c @@ -0,0 +1,31 @@ +/* { dg-do compile } */ +/* { dg-require-effective-target bswap32 } */ +/* { dg-options "-O2 -fdump-tree-bswap" } */ +/* { dg-additional-options "-march=z900" { target s390-*-* } } */ + +struct L { unsigned int l[2]; }; +union U { double a; struct L l; } u; + +void +foo (double a, struct L *p) +{ + u.a = a; + struct L l = u.l, m; + m.l[0] = (((l.l[1] & 0xff000000) >> 24) + | ((l.l[1] & 0x00ff0000) >> 8) + | ((l.l[1] & 0x0000ff00) << 8) + | ((l.l[1] & 0x000000ff) << 24)); + m.l[1] = (((l.l[0] & 0xff000000) >> 24) + | ((l.l[0] & 0x00ff0000) >> 8) + | ((l.l[0] & 0x0000ff00) << 8) + | ((l.l[0] & 0x000000ff) << 24)); + *p = m; +} + +void +bar (double a, struct L *p) +{ + foo (a, p); +} + +/* { dg-final { scan-tree-dump-times "32 bit bswap implementation found at" 2 "bswap" } } */ diff --git a/gcc/tree-ssa-math-opts.c b/gcc/tree-ssa-math-opts.c index 81688cd096c..0b0c86674f4 100644 --- a/gcc/tree-ssa-math-opts.c +++ b/gcc/tree-ssa-math-opts.c @@ -2051,6 +2051,9 @@ init_symbolic_number (struct symbolic_number *n, tree src) { int size; + if (! INTEGRAL_TYPE_P (TREE_TYPE (src))) + return false; + n->base_addr = n->offset = n->alias_set = n->vuse = NULL_TREE; /* Set up the symbolic number N by setting each byte to a value between 1 and -- 2.30.2