From b5f303f092e873d88d2b9459deb105e20ff5222c Mon Sep 17 00:00:00 2001 From: Nick Clifton Date: Mon, 24 Jan 2000 19:38:04 +0000 Subject: [PATCH] Remove use of a GCC extension when allocating local arrays. --- bfd/ChangeLog | 5 +++++ bfd/coffcode.h | 31 ++++++++++++++++++++++++++----- 2 files changed, 31 insertions(+), 5 deletions(-) diff --git a/bfd/ChangeLog b/bfd/ChangeLog index c37eee2ba5d..97b85422e35 100644 --- a/bfd/ChangeLog +++ b/bfd/ChangeLog @@ -1,3 +1,8 @@ +2000-01-24 Robert Lipe (robertl@sco.com) + + * coffcode.h (coff_write_object_contents): Get buff via bfd_malloc + instead of using GNU C extension. + 2000-01-21 Nick Clifton * libbfd.c (bfd_read): Do not attempt to get a negativly sized diff --git a/bfd/coffcode.h b/bfd/coffcode.h index 222089f16da..ace39e1d114 100644 --- a/bfd/coffcode.h +++ b/bfd/coffcode.h @@ -3680,20 +3680,41 @@ coff_write_object_contents (abfd) /* now write them */ if (bfd_seek (abfd, (file_ptr) 0, SEEK_SET) != 0) return false; + { - char buff[bfd_coff_filhsz (abfd)]; + char * buff; + bfd_size_type amount; + + buff = bfd_malloc (bfd_coff_filhsz (abfd)); + if (buff == NULL) + return false; + coff_swap_filehdr_out (abfd, (PTR) & internal_f, (PTR) buff); - if (bfd_write ((PTR) buff, 1, bfd_coff_filhsz (abfd), abfd) - != bfd_coff_filhsz (abfd)) + amount = bfd_write ((PTR) buff, 1, bfd_coff_filhsz (abfd), abfd); + + free (buff); + + if (amount != bfd_coff_filhsz (abfd)) return false; } + if (abfd->flags & EXEC_P) { /* Note that peicode.h fills in a PEAOUTHDR, not an AOUTHDR. include/coff/pe.h sets AOUTSZ == sizeof(PEAOUTHDR)) */ - char buff[bfd_coff_aoutsz (abfd)]; + char * buff; + bfd_size_type amount; + + buff = bfd_malloc (bfd_coff_aoutsz (abfd)); + if (buff == NULL) + return false; + coff_swap_aouthdr_out (abfd, (PTR) & internal_a, (PTR) buff); - if (bfd_write ((PTR) buff, 1, bfd_coff_aoutsz (abfd), abfd) != bfd_coff_aoutsz (abfd)) + amount = bfd_write ((PTR) buff, 1, bfd_coff_aoutsz (abfd), abfd); + + free (buff); + + if (amount != bfd_coff_aoutsz (abfd)) return false; } #ifdef RS6000COFF_C -- 2.30.2