From b66c195dcd45451b987e6abcd481238ea132a01d Mon Sep 17 00:00:00 2001 From: Tim King Date: Tue, 15 Dec 2015 13:29:49 -0800 Subject: [PATCH] Moving SExpr(bool) out of the header into sexpr.cpp to be less verbose about the warning. --- src/expr/sexpr.cpp | 9 +++++++++ src/expr/sexpr.h | 9 +-------- 2 files changed, 10 insertions(+), 8 deletions(-) diff --git a/src/expr/sexpr.cpp b/src/expr/sexpr.cpp index a321f85aa..b8ffca5e5 100644 --- a/src/expr/sexpr.cpp +++ b/src/expr/sexpr.cpp @@ -42,6 +42,15 @@ std::ostream& operator<<(std::ostream& out, PrettySExprs ps) { return out; } +#warning "TODO: Discuss this change with Clark." +SExpr::SExpr(bool value) : + d_sexprType(SEXPR_KEYWORD), + d_integerValue(0), + d_rationalValue(0), + d_stringValue(value ? "true" : "false"), + d_children() { +} + std::string SExpr::toString() const { std::stringstream ss; ss << (*this); diff --git a/src/expr/sexpr.h b/src/expr/sexpr.h index f30045c68..158be0efb 100644 --- a/src/expr/sexpr.h +++ b/src/expr/sexpr.h @@ -157,14 +157,7 @@ public: * This adds a convenience wrapper to SExpr to cast from bools. * This is internally handled as the strings "true" and "false" */ - SExpr(bool value) : -#warning "TODO: Discuss this change with Clark." - d_sexprType(SEXPR_KEYWORD), - d_integerValue(0), - d_rationalValue(0), - d_stringValue(value ? "true" : "false"), - d_children() { - } + SExpr(bool value); SExpr(const Keyword& value) : d_sexprType(SEXPR_KEYWORD), -- 2.30.2