From b6735d9ac58384640379f449db791bc59ce4f854 Mon Sep 17 00:00:00 2001 From: Georg-Johann Lay Date: Wed, 26 Oct 2016 09:46:44 +0000 Subject: [PATCH] gen-pass-instances.awk is sensitive to the order in which passes are added... gen-pass-instances.awk is sensitive to the order in which passes are added; passes that appear later have to be added first. PR target/71676 PR target/71678 * config/avr/avr-passes.def: Swap order of directives for gen-pass-instances.awk. From-SVN: r241547 --- gcc/ChangeLog | 10 ++++++++++ gcc/config/avr/avr-passes.def | 23 +++++++++++++---------- 2 files changed, 23 insertions(+), 10 deletions(-) diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 465761fb732..5a93e88a97b 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,13 @@ +2016-10-26 Georg-Johann Lay + + gen-pass-instances.awk is sensitive to the order in which + passes are added; passes that appear later have to be added first. + + PR target/71676 + PR target/71678 + * config/avr/avr-passes.def: Swap order of directives for + gen-pass-instances.awk. + 2016-10-25 Jeff Law * config/vax/vax.c (vad_address_cost_1): Add missing FALLTHRU comment. diff --git a/gcc/config/avr/avr-passes.def b/gcc/config/avr/avr-passes.def index b536a22ddd6..4ca67b1235d 100644 --- a/gcc/config/avr/avr-passes.def +++ b/gcc/config/avr/avr-passes.def @@ -17,6 +17,19 @@ along with GCC; see the file COPYING3. If not see . */ +/* FIXME: We have to add the last pass first, otherwise + gen-pass-instances.awk won't work as expected. */ + +/* This avr-specific pass (re)computes insn notes, in particular REG_DEAD + notes which are used by `avr.c::reg_unused_after' and branch offset + computations. These notes must be correct, i.e. there must be no + dangling REG_DEAD notes; otherwise wrong code might result, cf. PR64331. + + DF needs (correct) CFG, hence right before free_cfg is the last + opportunity to rectify notes. */ + +INSERT_PASS_BEFORE (pass_free_cfg, 1, avr_pass_recompute_notes); + /* casesi uses a SImode switch index which is quite costly as most code will work on HImode or QImode. The following pass runs right after .expand and tries to fix such situations by operating on the original mode. This @@ -27,13 +40,3 @@ insns withaout any insns in between. */ INSERT_PASS_AFTER (pass_expand, 1, avr_pass_casesi); - -/* This avr-specific pass (re)computes insn notes, in particular REG_DEAD - notes which are used by `avr.c::reg_unused_after' and branch offset - computations. These notes must be correct, i.e. there must be no - dangling REG_DEAD notes; otherwise wrong code might result, cf. PR64331. - - DF needs (correct) CFG, hence right before free_cfg is the last - opportunity to rectify notes. */ - -INSERT_PASS_BEFORE (pass_free_cfg, 1, avr_pass_recompute_notes); -- 2.30.2