From b6f9caee52be22ec3ff46f2773aef473625b8033 Mon Sep 17 00:00:00 2001 From: Tom Tromey Date: Mon, 17 Feb 2020 10:00:26 -0700 Subject: [PATCH] Fix gdbserver-without-gdb build An earlier patch changed gdbserver to use the already-built top-level gnulib and gdbsupport. However, if one did a build that did not include gdb, then gdbserver would fail to build. The problem is that configure.ac only adds gnulib and gdbsupport to the build when gdb is being built. This patch fixes the problem by arranging for this to happen when gdbserver is built. ChangeLog 2020-02-17 Tom Tromey * configure: Rebuild. * configure.ac (configdirs): Add gnulib and gdbsupport when building gdbserver. --- ChangeLog | 6 ++++++ configure | 18 +++++++++++------- configure.ac | 18 +++++++++++------- 3 files changed, 28 insertions(+), 14 deletions(-) diff --git a/ChangeLog b/ChangeLog index 7f6486f4118..880ffdd70c9 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2020-02-17 Tom Tromey + + * configure: Rebuild. + * configure.ac (configdirs): Add gnulib and gdbsupport when building + gdbserver. + 2020-02-14 Tom Tromey * Makefile.in: Rebuild. diff --git a/configure b/configure index 8a3e7026f0b..1c5403e9e4d 100755 --- a/configure +++ b/configure @@ -7360,13 +7360,17 @@ esac CONFIGURE_GDB_TK=`echo ${GDB_TK} | sed s/-all-/-configure-/g` INSTALL_GDB_TK=`echo ${GDB_TK} | sed s/-all-/-install-/g` -# gdb depends on gnulib and gdbsupport, but as nothing else does, only -# include them if gdb is built. -if echo " ${configdirs} " | grep " gdb " > /dev/null 2>&1 ; then - # The Makefile provides the ordering, so it's enough here to add to - # the list. - configdirs="${configdirs} gnulib gdbsupport" -fi +# gdb and gdbserver depend on gnulib and gdbsupport, but as nothing +# else does, only include them if one of these is built. The Makefile +# provides the ordering, so it's enough here to add to the list. +case " ${configdirs} " in + *\ gdb\ *) + configdirs="${configdirs} gnulib gdbsupport" + ;; + *\ gdbserver\ *) + configdirs="${configdirs} gnulib gdbsupport" + ;; +esac # Strip out unwanted targets. diff --git a/configure.ac b/configure.ac index 35a9c1867d2..f3065091c26 100644 --- a/configure.ac +++ b/configure.ac @@ -2746,13 +2746,17 @@ esac CONFIGURE_GDB_TK=`echo ${GDB_TK} | sed s/-all-/-configure-/g` INSTALL_GDB_TK=`echo ${GDB_TK} | sed s/-all-/-install-/g` -# gdb depends on gnulib and gdbsupport, but as nothing else does, only -# include them if gdb is built. -if echo " ${configdirs} " | grep " gdb " > /dev/null 2>&1 ; then - # The Makefile provides the ordering, so it's enough here to add to - # the list. - configdirs="${configdirs} gnulib gdbsupport" -fi +# gdb and gdbserver depend on gnulib and gdbsupport, but as nothing +# else does, only include them if one of these is built. The Makefile +# provides the ordering, so it's enough here to add to the list. +case " ${configdirs} " in + *\ gdb\ *) + configdirs="${configdirs} gnulib gdbsupport" + ;; + *\ gdbserver\ *) + configdirs="${configdirs} gnulib gdbsupport" + ;; +esac # Strip out unwanted targets. -- 2.30.2