From b7571e1e6fed2ee52143797e17fcca487e894b92 Mon Sep 17 00:00:00 2001 From: Christophe Lyon Date: Thu, 16 Mar 2023 13:03:40 +0000 Subject: [PATCH] Re: Add --enable-linker-version option The recently-added ld-version*.d tests expect .*GNU ld \(GNU Binutils\) 2.* in the .comment section. However, when buidling --with-pkgversion=XXX, we get GNU ld (XXX) 2.[...] instead, leading to a spurious FAIL. This small patch replaces "GNU Binutils" with ".*" instead. I inspected other testcases to see if we already had similar occurrences but I couldn't see any, so I hope this fix is OK for the purpose? Thanks, Christophe --- ld/testsuite/ld-scripts/ld-version-2.d | 2 +- ld/testsuite/ld-scripts/ld-version.d | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/ld/testsuite/ld-scripts/ld-version-2.d b/ld/testsuite/ld-scripts/ld-version-2.d index c8738fd82d6..c696c093d69 100644 --- a/ld/testsuite/ld-scripts/ld-version-2.d +++ b/ld/testsuite/ld-scripts/ld-version-2.d @@ -4,4 +4,4 @@ # target: [is_elf_format] String dump of section '.comment': -.*GNU ld \(GNU Binutils\) 2.* +.*GNU ld \(.*\) 2.* diff --git a/ld/testsuite/ld-scripts/ld-version.d b/ld/testsuite/ld-scripts/ld-version.d index a55fc5e003b..7d1ffc5a45e 100644 --- a/ld/testsuite/ld-scripts/ld-version.d +++ b/ld/testsuite/ld-scripts/ld-version.d @@ -4,4 +4,4 @@ # target: [is_elf_format] String dump of section '.comment': -.*GNU ld \(GNU Binutils\) 2.* +.*GNU ld \(.*\) 2.* -- 2.30.2