From b76f3a42371cb0d83a1128a434852447da76b5e9 Mon Sep 17 00:00:00 2001 From: Tom de Vries Date: Wed, 11 Mar 2020 08:37:04 +0100 Subject: [PATCH] [gdb/testsuite] Set EDITOR to true before using edit The test-case gdb.base/list-ambiguous.exp normally passes, but with target board readnow, some tests fail. In particular, for this test, edit doesn't fail as expected: ... # While at it, test the "edit" command as well, since it shares # code with "list". gdb_test "edit $symbol" \ "Specified line is ambiguous:\r\n${h0_re}\r\n${h1_re}" ... and the editor is launched, in my case: ... $ echo $EDITOR /home/vries/bin/emacs-nw.sh ... which result in all subsequent tests failing with timeout, and an editor backup file in my sources: ... $ git status --ignored On branch master Ignored files: (use "git add -f ..." to include in what will be committed) gdb/testsuite/gdb.base/#list-ambiguous0.c# nothing to commit, working tree clean ... Fix this by setting EDITOR to true before starting gdb in this test-case. Tested on x86_64-linux. gdb/testsuite/ChangeLog: 2020-03-11 Tom de Vries * gdb.base/list-ambiguous.exp: Set EDITOR to true. --- gdb/testsuite/ChangeLog | 4 ++++ gdb/testsuite/gdb.base/list-ambiguous.exp | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index c5aa0e67053..46442c5e12f 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,7 @@ +2020-03-11 Tom de Vries + + * gdb.base/list-ambiguous.exp: Set EDITOR to true. + 2020-03-11 Tom de Vries * gdb.ada/access_to_packed_array.exp: Test printing of expanded diff --git a/gdb/testsuite/gdb.base/list-ambiguous.exp b/gdb/testsuite/gdb.base/list-ambiguous.exp index 8d63938fb77..13c15d2893c 100644 --- a/gdb/testsuite/gdb.base/list-ambiguous.exp +++ b/gdb/testsuite/gdb.base/list-ambiguous.exp @@ -18,6 +18,10 @@ standard_testfile list-ambiguous0.c list-ambiguous1.c +# Set EDITOR to true to prevent that GDB's edit command starts an actual +# editor. +setenv EDITOR true + if {[prepare_for_testing "failed to prepare" $testfile [list $srcfile $srcfile2] \ {debug}]} { return -1 -- 2.30.2