From b8e59292e6a19673ca34a8aaeeb26d75dca23f3f Mon Sep 17 00:00:00 2001 From: Mark Kettenis Date: Fri, 29 Apr 2016 17:31:10 +0100 Subject: [PATCH] egl/x11: resolve "initialization from incompatible pointer type" warning With earlier commit we've moved a few functions and changing the argument type from _EGLDisplay * to struct dri2_egl_display *. The latter is effectively a wrapper around the former, thus functionality was preserved, although GCC rightfully warned us about the misuse. Add a simple wrapper that casts and propagates the correct type. Fixes: 9bbf3737f9c ("egl/x11: authenticate before doing chipset id ioctls") Cc: "11.2 11.1" Reported-by: Matt Turner Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/platform_x11.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/src/egl/drivers/dri2/platform_x11.c b/src/egl/drivers/dri2/platform_x11.c index b6385f708da..c0a4005d08e 100644 --- a/src/egl/drivers/dri2/platform_x11.c +++ b/src/egl/drivers/dri2/platform_x11.c @@ -543,7 +543,7 @@ dri2_x11_flush_front_buffer(__DRIdrawable * driDrawable, void *loaderPrivate) } static int -dri2_x11_authenticate(struct dri2_egl_display *dri2_dpy, uint32_t id) +dri2_x11_do_authenticate(struct dri2_egl_display *dri2_dpy, uint32_t id) { xcb_dri2_authenticate_reply_t *authenticate; xcb_dri2_authenticate_cookie_t authenticate_cookie; @@ -583,7 +583,7 @@ dri2_x11_local_authenticate(struct dri2_egl_display *dri2_dpy) return EGL_FALSE; } - if (dri2_x11_authenticate(dri2_dpy, magic) < 0) { + if (dri2_x11_do_authenticate(dri2_dpy, magic) < 0) { _eglLog(_EGL_WARNING, "DRI2: failed to authenticate"); return EGL_FALSE; } @@ -712,6 +712,14 @@ dri2_x11_connect(struct dri2_egl_display *dri2_dpy) return EGL_TRUE; } +static int +dri2_x11_authenticate(_EGLDisplay *disp, uint32_t id) +{ + struct dri2_egl_display *dri2_dpy = dri2_egl_display(disp); + + return dri2_x11_do_authenticate(dri2_dpy, id); +} + static EGLBoolean dri2_x11_add_configs_for_visuals(struct dri2_egl_display *dri2_dpy, _EGLDisplay *disp, bool supports_preserved) -- 2.30.2