From b9dd19477d46d51f4de800bf4cb5dcf1ed90d3a3 Mon Sep 17 00:00:00 2001 From: Joel Brobecker Date: Wed, 1 May 2013 14:54:18 +0000 Subject: [PATCH] Fix various -Wpointer-sign warnings in darwin-nat.c gdb/ChangeLog: * darwin-nat.c (darwin_read_write_inferior): Change types of parameters rdaddr and wraddr to "gdb_byte *". Change type of copy_count to "mach_msg_type_number_t". (darwin_read_dyld_info): Change type of parameter rdaddr to "gdb_byte *". --- gdb/ChangeLog | 8 ++++++++ gdb/darwin-nat.c | 8 +++++--- 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index b02799c6204..654e4fc0c0b 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,11 @@ +2013-05-01 Joel Brobecker + + * darwin-nat.c (darwin_read_write_inferior): Change types + of parameters rdaddr and wraddr to "gdb_byte *". Change type + of copy_count to "mach_msg_type_number_t". + (darwin_read_dyld_info): Change type of parameter + rdaddr to "gdb_byte *". + 2013-05-01 Joel Brobecker * solib-ia64-hpux.c (ia64_hpux_read_dynamic_info): Change cast diff --git a/gdb/darwin-nat.c b/gdb/darwin-nat.c index 1344101c7cb..c4280a4cf69 100644 --- a/gdb/darwin-nat.c +++ b/gdb/darwin-nat.c @@ -1688,14 +1688,15 @@ darwin_thread_alive (struct target_ops *ops, ptid_t ptid) Return 0 on failure; number of bytes read / writen otherwise. */ static int darwin_read_write_inferior (task_t task, CORE_ADDR addr, - char *rdaddr, const char *wraddr, int length) + gdb_byte *rdaddr, const gdb_byte *wraddr, + int length) { kern_return_t kret; mach_vm_address_t offset = addr & (mach_page_size - 1); mach_vm_address_t low_address = (mach_vm_address_t) (addr - offset); mach_vm_size_t aligned_length = (mach_vm_size_t) PAGE_ROUND (offset + length); pointer_t copied; - int copy_count; + mach_msg_type_number_t copy_count; mach_vm_size_t remaining_length; mach_vm_address_t region_address; mach_vm_size_t region_length; @@ -1821,7 +1822,8 @@ out: #ifdef TASK_DYLD_INFO_COUNT /* This is not available in Darwin 9. */ static int -darwin_read_dyld_info (task_t task, CORE_ADDR addr, char *rdaddr, int length) +darwin_read_dyld_info (task_t task, CORE_ADDR addr, gdb_byte *rdaddr, + int length) { struct task_dyld_info task_dyld_info; mach_msg_type_number_t count = TASK_DYLD_INFO_COUNT; -- 2.30.2