From ba284a13ddc381bf8d13d736256820c74b961821 Mon Sep 17 00:00:00 2001 From: "Daniel R. Carvalho" Date: Fri, 25 Dec 2020 17:43:11 -0300 Subject: [PATCH] base: Fix uninitialized variable in Flag This was uninitialized, and was breaking expected values under certain situations. Change-Id: If51ab6ae038c7c397bc83de1c73af348c1db4ef8 Signed-off-by: Daniel R. Carvalho Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/38707 Reviewed-by: Bobby R. Bruce Reviewed-by: Andreas Sandberg Maintainer: Bobby R. Bruce Tested-by: kokoro --- src/base/debug.cc | 2 ++ src/base/debug.hh | 8 +++----- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/base/debug.cc b/src/base/debug.cc index 45d9f9d59..9cfd45ec4 100644 --- a/src/base/debug.cc +++ b/src/base/debug.cc @@ -100,6 +100,8 @@ Flag::Flag(const char *name, const char *desc) panic("Flag %s already defined!", name); ++allFlagsVersion; + + sync(); } Flag::~Flag() diff --git a/src/base/debug.hh b/src/base/debug.hh index 7cc71375b..6006b14b9 100644 --- a/src/base/debug.hh +++ b/src/base/debug.hh @@ -82,15 +82,13 @@ class Flag class SimpleFlag : public Flag { protected: - bool _tracing; // tracing is enabled and flag is on - bool _status; // flag status + bool _tracing = false; // tracing is enabled and flag is on + bool _status = false; // flag status void sync() override { _tracing = _globalEnable && _status; } public: - SimpleFlag(const char *name, const char *desc) - : Flag(name, desc), _status(false) - { } + SimpleFlag(const char *name, const char *desc) : Flag(name, desc) {} bool status() const override { return _tracing; } -- 2.30.2