From bb7f094b3711614953ee699950c7b728efc48c54 Mon Sep 17 00:00:00 2001 From: Brian Paul Date: Thu, 25 Aug 2016 18:04:51 -0600 Subject: [PATCH] svga: add some comments in the svga_surface struct Give more info about backing resources/surfaces. Reviewed-by: Neha Bhende --- src/gallium/drivers/svga/svga_surface.h | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/src/gallium/drivers/svga/svga_surface.h b/src/gallium/drivers/svga/svga_surface.h index c166791e1e7..2f003b22cc6 100644 --- a/src/gallium/drivers/svga/svga_surface.h +++ b/src/gallium/drivers/svga/svga_surface.h @@ -45,6 +45,12 @@ struct svga_surface struct pipe_surface base; struct svga_host_surface_cache_key key; + + /* + * Note that the handle may point at a secondary / backing resource + * created by svga_texture_view_surface() which is something other + * than svga_texture(base->texture)->handle. + */ struct svga_winsys_surface *handle; unsigned real_layer; @@ -55,6 +61,16 @@ struct svga_surface /* VGPU10 */ SVGA3dRenderTargetViewId view_id; + + /* + * As with 'handle' above, this may point to a secondary / backing resource. + * We can't have one resource bound as both a render target and a shader + * resource at the same time. But we sometimes want to do that, such as + * for mipmap generation where we sample from one level and render into + * another. + * In this situation, the backed surface is the render target while the + * original surface is the shader resource. + */ struct svga_surface *backed; }; -- 2.30.2