From bbefd0a9264348d04783d3d374c2104ae468c799 Mon Sep 17 00:00:00 2001 From: Alan Modra Date: Wed, 12 Mar 2014 10:33:26 +1030 Subject: [PATCH] objcopy/strip ELF program header p_vaddr confusion copy_elf_program_header has logic to reject non-alloc sections when calculating p_vaddr offset for padding, but blithely assumed the first section in a segment was allocated. PR 16690 * elf.c (copy_elf_program_header): Ignore first section lma if non-alloc. --- bfd/ChangeLog | 6 ++++++ bfd/elf.c | 5 +++-- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/bfd/ChangeLog b/bfd/ChangeLog index fd3135a886e..c9887c35e6b 100644 --- a/bfd/ChangeLog +++ b/bfd/ChangeLog @@ -1,3 +1,9 @@ +2014-03-12 Alan Modra + + PR 16690 + * elf.c (copy_elf_program_header): Ignore first section lma if + non-alloc. + 2014-03-11 Alan Modra PR 16686 diff --git a/bfd/elf.c b/bfd/elf.c index ce7878c18ff..3ded683efe4 100644 --- a/bfd/elf.c +++ b/bfd/elf.c @@ -6259,7 +6259,7 @@ copy_elf_program_header (bfd *ibfd, bfd *obfd) phdr_included = TRUE; } - lowest_section = first_section; + lowest_section = NULL; if (section_count != 0) { unsigned int isec = 0; @@ -6276,7 +6276,8 @@ copy_elf_program_header (bfd *ibfd, bfd *obfd) { bfd_vma seg_off; - if (section->lma < lowest_section->lma) + if (lowest_section == NULL + || section->lma < lowest_section->lma) lowest_section = section; /* Section lmas are set up from PT_LOAD header -- 2.30.2