From bc303e5d6c2dd33086478f80fd1d3096d4e1bc01 Mon Sep 17 00:00:00 2001 From: Nick Clifton Date: Tue, 14 Feb 2017 15:10:34 +0000 Subject: [PATCH] Fix invalid memory access displayiing contents of sections. PR binutils/21159 * readelf.c (dump_section_as_strings): Reset the start address if no decompression is perfromed. (dump_section_as_bytes): Likewise. --- binutils/ChangeLog | 7 +++++++ binutils/readelf.c | 10 +++++++++- 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/binutils/ChangeLog b/binutils/ChangeLog index 4f9bdfa75dc..9d3f7e2a266 100644 --- a/binutils/ChangeLog +++ b/binutils/ChangeLog @@ -1,3 +1,10 @@ +2017-02-14 Nick Clifton + + PR binutils/21159 + * readelf.c (dump_section_as_strings): Reset the start address if + no decompression is perfromed. + (dump_section_as_bytes): Likewise. + 2017-02-14 Nick Clifton PR binutils/21158 diff --git a/binutils/readelf.c b/binutils/readelf.c index c4bddcdb711..150b68025be 100644 --- a/binutils/readelf.c +++ b/binutils/readelf.c @@ -12706,6 +12706,8 @@ dump_section_as_strings (Elf_Internal_Shdr * section, FILE * file) return; } } + else + start = real_start; } /* If the section being dumped has relocations against it the user might @@ -12840,14 +12842,19 @@ dump_section_as_bytes (Elf_Internal_Shdr * section, { if (uncompress_section_contents (& start, uncompressed_size, & new_size)) - section_size = new_size; + { + section_size = new_size; + } else { error (_("Unable to decompress section %s\n"), printable_section_name (section)); + /* FIXME: Print the section anyway ? */ return; } } + else + start = real_start; } if (relocate) @@ -13014,6 +13021,7 @@ load_specific_debug_section (enum dwarf_section_display_enum debug, return 0; } } + section->size = size; } -- 2.30.2