From bcc3a8bca12aa077e6d40880f2d41f05864d4798 Mon Sep 17 00:00:00 2001 From: Nick Clifton Date: Thu, 2 Jun 2016 16:20:27 +0100 Subject: [PATCH] Fix a seg-fault when stripping a corrupt binary. PR 20089 * objcopy.c (group_signature): Fail if the input symbol table has not been loaded. --- binutils/ChangeLog | 4 ++++ binutils/objcopy.c | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/binutils/ChangeLog b/binutils/ChangeLog index 9dfaf2b8f27..a91b99b4e7e 100644 --- a/binutils/ChangeLog +++ b/binutils/ChangeLog @@ -1,5 +1,9 @@ 2016-06-02 Nick Clifton + PR 20089 + * objcopy.c (group_signature): Fail if the input symbol table has + not been loaded. + * dwarf.c (display_debug_frames): Do not display any interpretation if the block consists solely of DW__CFA_NOPs. diff --git a/binutils/objcopy.c b/binutils/objcopy.c index 94267616caf..98332cd3dc2 100644 --- a/binutils/objcopy.c +++ b/binutils/objcopy.c @@ -1125,6 +1125,10 @@ group_signature (asection *group) bfd *abfd = group->owner; Elf_Internal_Shdr *ghdr; + /* PR 20089: An earlier error may have prevented us from loading the symbol table. */ + if (isympp == NULL) + return NULL; + if (bfd_get_flavour (abfd) != bfd_target_elf_flavour) return NULL; -- 2.30.2