From bcf8470303e06cb6cd5294608aad913fe5580f45 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Cl=C3=A9ment=20Chigot?= Date: Tue, 15 Jun 2021 11:06:52 +0200 Subject: [PATCH] gas: handle csect in bss section for XCOFF Latest gcc versions are now generating csects instead of .lcomm for bss symbols. Some adjustements are needed in order to handle them. * config/tc-ppc.c (md_begin): Create bss section with dummy symbol. (ppc_frob_symbol): Output XTY_CM for bss csects. (ppc_fix_adjustable): Adjust condition to avoid bss csects. --- gas/ChangeLog | 7 +++++++ gas/config/tc-ppc.c | 10 +++++++--- 2 files changed, 14 insertions(+), 3 deletions(-) diff --git a/gas/ChangeLog b/gas/ChangeLog index ad2013708c4..821cc810e07 100644 --- a/gas/ChangeLog +++ b/gas/ChangeLog @@ -1,3 +1,10 @@ +2021-06-17 Clément Chigot + + * config/tc-ppc.c (md_begin): Create bss section with dummy + symbol. + (ppc_frob_symbol): Output XTY_CM for bss csects. + (ppc_fix_adjustable): Adjust condition to avoid bss csects. + 2021-06-17 Clément Chigot * config/tc-ppc.c (md_apply_fix): Adjust addend to nullify diff --git a/gas/config/tc-ppc.c b/gas/config/tc-ppc.c index 72bf5ce75d4..ad85d3863b0 100644 --- a/gas/config/tc-ppc.c +++ b/gas/config/tc-ppc.c @@ -1883,7 +1883,7 @@ md_begin (void) data csects. These symbols will not be output. */ ppc_init_xcoff_section (&ppc_xcoff_text_section, text_section, true); ppc_init_xcoff_section (&ppc_xcoff_data_section, data_section, true); - ppc_init_xcoff_section (&ppc_xcoff_bss_section, bss_section, false); + ppc_init_xcoff_section (&ppc_xcoff_bss_section, bss_section, true); #endif } @@ -5986,7 +5986,10 @@ ppc_frob_symbol (symbolS *sym) a->x_csect.x_scnlen.l = (S_GET_VALUE (symbol_get_tc (sym)->next) - S_GET_VALUE (sym)); } - a->x_csect.x_smtyp = (symbol_get_tc (sym)->align << 3) | XTY_SD; + if (symbol_get_tc (sym)->symbol_class == XMC_BS) + a->x_csect.x_smtyp = (symbol_get_tc (sym)->align << 3) | XTY_CM; + else + a->x_csect.x_smtyp = (symbol_get_tc (sym)->align << 3) | XTY_SD; } else if (S_GET_SEGMENT (sym) == bss_section || S_GET_SEGMENT (sym) == ppc_xcoff_tbss_section.segment) @@ -6415,7 +6418,8 @@ ppc_fix_adjustable (fixS *fix) /* Adjust a reloc against a .lcomm symbol to be against the base .lcomm. */ if (symseg == bss_section - && ! S_IS_EXTERNAL (fix->fx_addsy)) + && ! S_IS_EXTERNAL (fix->fx_addsy) + && symbol_get_tc (fix->fx_addsy)->subseg == 0) { symbolS *sy = symbol_get_frag (fix->fx_addsy)->fr_symbol; -- 2.30.2