From bcfd78e4489f538e34138269650fc6cbe8c9d75f Mon Sep 17 00:00:00 2001 From: Rafael Antognolli Date: Wed, 24 Jan 2018 16:33:58 -0800 Subject: [PATCH] i965/gen10: Re-enable push constants. The GPU hang caused by push constants is apparently fixed, so let's enable them again. Signed-off-by: Rafael Antognolli Cc: "18.0" Reviewed-by: Kenneth Graunke Reviewed-by: Jason Ekstrand --- src/intel/compiler/brw_fs.cpp | 9 --------- 1 file changed, 9 deletions(-) diff --git a/src/intel/compiler/brw_fs.cpp b/src/intel/compiler/brw_fs.cpp index 09adcbc2df1..6fb46e7374c 100644 --- a/src/intel/compiler/brw_fs.cpp +++ b/src/intel/compiler/brw_fs.cpp @@ -2096,15 +2096,6 @@ fs_visitor::assign_constant_locations() if (subgroup_id_index >= 0) max_push_components--; /* Save a slot for the thread ID */ - /* FIXME: We currently have some GPU hangs that happen apparently when using - * push constants. Since we have no solution for such hangs yet, just - * go ahead and use pull constants for now. - */ - if (devinfo->gen == 10 && compiler->supports_pull_constants) { - compiler->shader_perf_log(log_data, "Disabling push constants."); - max_push_components = 0; - } - /* We push small arrays, but no bigger than 16 floats. This is big enough * for a vec4 but hopefully not large enough to push out other stuff. We * should probably use a better heuristic at some point. -- 2.30.2