From bd497355ea57d629a5c1ac610308bafd5b0eff8f Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Wed, 13 Jan 2021 20:25:58 -0500 Subject: [PATCH] gdb: remove target_ops::commit_resume implementation in record-{btrace, full}.c The previous patch made the commit_resume implementations in the record targets unnecessary, as the remote target's commit_resume implementation won't commit-resume threads for which it didn't see a resume. This patch removes them. gdb/ChangeLog: * record-btrace.c (class record_btrace_target): Remove. (record_btrace_target::commit_resume): Remove. * record-full.c (class record_full_target): Remove. (record_full_target::commit_resume): Remove. Change-Id: I3a68d3d726fb09d8b7165b4edefc330d27803b27 --- gdb/ChangeLog | 7 +++++++ gdb/record-btrace.c | 11 ----------- gdb/record-full.c | 10 ---------- 3 files changed, 7 insertions(+), 21 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index cd4865619c8..bd039a7e65b 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,10 @@ +2021-01-13 Simon Marchi + + * record-btrace.c (class record_btrace_target): Remove. + (record_btrace_target::commit_resume): Remove. + * record-full.c (class record_full_target): Remove. + (record_full_target::commit_resume): Remove. + 2021-01-13 Simon Marchi * remote.c (enum class resume_state): New. diff --git a/gdb/record-btrace.c b/gdb/record-btrace.c index 5924e83898a..81686ee867b 100644 --- a/gdb/record-btrace.c +++ b/gdb/record-btrace.c @@ -116,7 +116,6 @@ public: const struct frame_unwind *get_tailcall_unwinder () override; - void commit_resume () override; void resume (ptid_t, int, enum gdb_signal) override; ptid_t wait (ptid_t, struct target_waitstatus *, target_wait_flags) override; @@ -2206,16 +2205,6 @@ record_btrace_target::resume (ptid_t ptid, int step, enum gdb_signal signal) } } -/* The commit_resume method of target record-btrace. */ - -void -record_btrace_target::commit_resume () -{ - if ((::execution_direction != EXEC_REVERSE) - && !record_is_replaying (minus_one_ptid)) - beneath ()->commit_resume (); -} - /* Cancel resuming TP. */ static void diff --git a/gdb/record-full.c b/gdb/record-full.c index 5ed9c1a428b..22eaaa4bb1b 100644 --- a/gdb/record-full.c +++ b/gdb/record-full.c @@ -267,7 +267,6 @@ public: const target_info &info () const override { return record_full_target_info; } - void commit_resume () override; void resume (ptid_t, int, enum gdb_signal) override; void disconnect (const char *, int) override; void detach (inferior *, int) override; @@ -1103,15 +1102,6 @@ record_full_target::resume (ptid_t ptid, int step, enum gdb_signal signal) target_async (1); } -/* "commit_resume" method for process record target. */ - -void -record_full_target::commit_resume () -{ - if (!RECORD_FULL_IS_REPLAY) - beneath ()->commit_resume (); -} - static int record_full_get_sig = 0; /* SIGINT signal handler, registered by "wait" method. */ -- 2.30.2