From be445d3ea3a7b4575c2dbac3d702e27e9ec3f125 Mon Sep 17 00:00:00 2001 From: "Juan A. Suarez Romero" Date: Mon, 12 Sep 2016 16:06:22 +0000 Subject: [PATCH] i965/vec4: keep original type when dealing with null registers Keep the original type when dealing with null registers. Especially because we do no want to introduce an implicit conversion between types that could affect the conditional flags. This affects especially when the original type is DF, and we are working on Ivybridge/Baytrail. v2 (Curro) - Fix typo. - Use retype() instead of applying the type directly. - Remove unneeded retype. Reviewed-by: Francisco Jerez --- src/intel/compiler/brw_vec4.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/intel/compiler/brw_vec4.cpp b/src/intel/compiler/brw_vec4.cpp index adbd85036e0..386057e3e3c 100644 --- a/src/intel/compiler/brw_vec4.cpp +++ b/src/intel/compiler/brw_vec4.cpp @@ -1984,6 +1984,7 @@ vec4_visitor::convert_to_hw_regs() case BAD_FILE: /* Probably unused. */ reg = brw_null_reg(); + reg = retype(reg, src.type); break; case MRF: @@ -2034,6 +2035,7 @@ vec4_visitor::convert_to_hw_regs() case BAD_FILE: reg = brw_null_reg(); + reg = retype(reg, dst.type); break; case IMM: -- 2.30.2