From beea5cc1bc2249389dc77ea0c86ab82dafd05bb5 Mon Sep 17 00:00:00 2001 From: Alan Modra Date: Sun, 22 Mar 2020 20:02:55 +1030 Subject: [PATCH] ARC: Use of uninitialised value * arc-dis.c (find_format): Use ISO C string concatenation rather than line continuation within a string. Don't access needs_limm before testing opcode != NULL. --- opcodes/ChangeLog | 6 ++++++ opcodes/arc-dis.c | 7 ++++--- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/opcodes/ChangeLog b/opcodes/ChangeLog index 06b81d7b547..eb3e4c32f29 100644 --- a/opcodes/ChangeLog +++ b/opcodes/ChangeLog @@ -1,3 +1,9 @@ +2020-03-22 Alan Modra + + * arc-dis.c (find_format): Use ISO C string concatenation rather + than line continuation within a string. Don't access needs_limm + before testing opcode != NULL. + 2020-03-22 Alan Modra * ns32k-dis.c (print_insn_arg): Update comment. diff --git a/opcodes/arc-dis.c b/opcodes/arc-dis.c index 9662c2fc53b..131aee6b34e 100644 --- a/opcodes/arc-dis.c +++ b/opcodes/arc-dis.c @@ -436,8 +436,9 @@ find_format (bfd_vma memaddr, opcode = arcExtMap_genOpcode (i, isa_mask, &errmsg); if (opcode == NULL) { - (*info->fprintf_func) (info->stream, "\ -An error occured while generating the extension instruction operations"); + (*info->fprintf_func) (info->stream, + _("An error occured while generating the " + "extension instruction operations")); *opcode_result = NULL; return FALSE; } @@ -452,7 +453,7 @@ An error occured while generating the extension instruction operations"); opcode = find_format_from_table (info, arc_opcodes, insn, *insn_len, isa_mask, &needs_limm, TRUE); - if (needs_limm && opcode != NULL) + if (opcode != NULL && needs_limm) { bfd_byte buffer[4]; int status; -- 2.30.2