From bf6e5d01d7b149e116a008bd4348983c6f56e9ba Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Thu, 12 Nov 2020 17:42:55 -0500 Subject: [PATCH] gdb/dwarf: fix call to dwarf2_queue_guard in dw2_do_instantiate_symtab It took me a while to understand why that would even compile: it looks like we pass a type name as a pointer, that makes no sense. By looking at the DWARF, I understood that the compiler actually interprets it as a function declaration. So the statement was doing nothing, no dwarf2_queue_guard was instantiated. Fix it by passing the right variable name. gdb/ChangeLog: * dwarf2/read.c (dw2_do_instantiate_symtab): Fix call to dwarf2_queue_guard. Change-Id: I3a7bdead9e8c39f8342a471f10181b85b8f0d801 --- gdb/ChangeLog | 5 +++++ gdb/dwarf2/read.c | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index b7e8f1f4624..abcd02bd170 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2020-11-12 Simon Marchi + + * dwarf2/read.c (dw2_do_instantiate_symtab): Fix call to + dwarf2_queue_guard. + 2020-11-12 Simon Marchi * dwarf2/read.c (dw2_do_instantiate_symtab): Fix typo in diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c index 5c3849bd43e..1b43fc8cdcd 100644 --- a/gdb/dwarf2/read.c +++ b/gdb/dwarf2/read.c @@ -2435,7 +2435,7 @@ dw2_do_instantiate_symtab (dwarf2_per_cu_data *per_cu, /* The destructor of dwarf2_queue_guard frees any entries left on the queue. After this point we're guaranteed to leave this function with the dwarf queue empty. */ - dwarf2_queue_guard q_guard (dwarf2_per_objfile); + dwarf2_queue_guard q_guard (per_objfile); if (!per_objfile->symtab_set_p (per_cu)) { -- 2.30.2