From c05da2e3418f71ea7d9d8d59c76dc6773ead608b Mon Sep 17 00:00:00 2001 From: Tim King Date: Fri, 2 Dec 2016 15:10:17 -0800 Subject: [PATCH] Cleaning up Statistics::copyFrom to avoid casts. --- src/util/statistics.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/util/statistics.cpp b/src/util/statistics.cpp index 8384a7bb1..368335f7e 100644 --- a/src/util/statistics.cpp +++ b/src/util/statistics.cpp @@ -52,10 +52,10 @@ StatisticsBase& StatisticsBase::operator=(const StatisticsBase& stats) { void Statistics::copyFrom(const StatisticsBase& stats) { // This is ugly, but otherwise we have to introduce a "friend" relation for // Base to its derived class (really obnoxious). - StatSet::const_iterator i_begin = ((const Statistics*) &stats)->d_stats.begin(); - StatSet::const_iterator i_end = ((const Statistics*) &stats)->d_stats.end(); - for(StatSet::const_iterator i = i_begin; i != i_end; ++i) { - SExprStat* p = new SExprStat((*i)->getName(), (*i)->getValue()); + const StatisticsBase::const_iterator i_begin = stats.begin(); + const StatisticsBase::const_iterator i_end = stats.end(); + for(StatisticsBase::const_iterator i = i_begin; i != i_end; ++i) { + SExprStat* p = new SExprStat((*i).first, (*i).second); d_stats.insert(p); } } -- 2.30.2