From c05fa167295864d50d460f0d92dbe0aa91a4f220 Mon Sep 17 00:00:00 2001 From: Brandon Potter Date: Thu, 17 Mar 2016 10:22:39 -0700 Subject: [PATCH] syscall_emul, style: refactor lseek --- src/sim/syscall_emul.cc | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/src/sim/syscall_emul.cc b/src/sim/syscall_emul.cc index 3dda05da7..a3acae19d 100644 --- a/src/sim/syscall_emul.cc +++ b/src/sim/syscall_emul.cc @@ -306,19 +306,13 @@ _llseekFunc(SyscallDesc *desc, int num, LiveProcess *p, ThreadContext *tc) uint64_t result = lseek(sim_fd, offset, whence); result = TheISA::htog(result); - if (result == (off_t)-1) { - //The seek failed. + if (result == (off_t)-1) return -errno; - } else { - // The seek succeeded. - // Copy "result" to "result_ptr" - // XXX We'll assume that the size of loff_t is 64 bits on the - // target platform - BufferArg result_buf(result_ptr, sizeof(result)); - memcpy(result_buf.bufferPtr(), &result, sizeof(result)); - result_buf.copyOut(tc->getMemProxy()); - return 0; - } + // Assuming that the size of loff_t is 64 bits on the target platform + BufferArg result_buf(result_ptr, sizeof(result)); + memcpy(result_buf.bufferPtr(), &result, sizeof(result)); + result_buf.copyOut(tc->getMemProxy()); + return 0; } -- 2.30.2