From c20c017b2cdd28aa93071151bb7e704541fde730 Mon Sep 17 00:00:00 2001 From: Gary Benson Date: Fri, 25 Sep 2020 14:44:07 +0100 Subject: [PATCH] Fix gdb.base/infcall-nested-structs-c++.exp with Clang gdb.base/infcall-nested-structs-c++.exp failed to build using Clang with many variations on the following error: gdb compile failed, /gdbtest/src/gdb/testsuite/gdb.base/infcall-nested-structs.c:207:46: warning: self-comparison always evaluates to true [-Wtautological-compare] This commit builds this testcase with -Wno-tautological-compare when using Clang, to avoid this failure. gdb/testsuite/ChangeLog: * gdb.base/infcall-nested-structs.exp.tcl: Add additional_flags=-Wno-tautological-compare for C++ tests when compiling using Clang. --- gdb/testsuite/ChangeLog | 6 ++++++ gdb/testsuite/gdb.base/infcall-nested-structs.exp.tcl | 7 +++++++ 2 files changed, 13 insertions(+) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index a19af885d39..2e35f6cdf1a 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,9 @@ +2020-09-25 Gary Benson + + * gdb.base/infcall-nested-structs.exp.tcl: Add + additional_flags=-Wno-tautological-compare for C++ + tests when compiling using Clang. + 2020-09-25 Gary Benson * lib/gdb.exp (gdb_compile): Pass "-x c++" earlier, and only diff --git a/gdb/testsuite/gdb.base/infcall-nested-structs.exp.tcl b/gdb/testsuite/gdb.base/infcall-nested-structs.exp.tcl index f7409612f80..907abe7ee85 100644 --- a/gdb/testsuite/gdb.base/infcall-nested-structs.exp.tcl +++ b/gdb/testsuite/gdb.base/infcall-nested-structs.exp.tcl @@ -33,6 +33,13 @@ if [support_complex_tests] { lappend compile_flags "additional_flags=-Wno-psabi" } +if { $lang == "c++" && [test_compiler_info clang*] } { + # Clang rightly deduces that the static member tests are + # tautological comparisons, so we need to inhibit that + # particular warning in order to build. + lappend compile_flags "additional_flags=-Wno-tautological-compare" +} + # Given N (0..25), return the corresponding alphabetic letter in upper # case. -- 2.30.2