From c2e863866d9b206c387d8fdc0f1bfa9f246e4355 Mon Sep 17 00:00:00 2001 From: Alan Modra Date: Fri, 26 Oct 2018 10:01:54 +1030 Subject: [PATCH] ld -r script fixes For ld -r, we generally set the VMA of sections to zero. This is done to make the output of ld -r most similar to that output by the assembler, which generally has sections starting at VMA zero. In some cases that covers for backend bugs which would mis-handle relocatable object files with non-zero section VMAs. This patch fixes a few sections that didn't have zero VMAs for ld -r. A missing zero on .note.gnu.build-id and .eh_frame_hdr doesn't matter much since these are linker generated symbols only output on final link, but it's good to be consistent. * Makefile.am (ei386beos.c, ei386go32.c): Correct dependencies. * Makefile.in: Regenerate. * scripttempl/elf.sc (.note.gnu.build-id, .eh_frame_hdr): Set address with ${RELOCATING-0}. * scripttempl/arclinux.sc: Likewise. * scripttempl/armbpabi.sc: Likewise. * scripttempl/avr.sc: Likewise. * scripttempl/elf64hppa.sc: Likewise. * scripttempl/elf_chaos.sc: Likewise. * scripttempl/elfarc.sc: Likewise. * scripttempl/elfxtensa.sc: Likewise. * scripttempl/mep.sc: Likewise. * scripttempl/nds32elf.sc: Likewise. * scripttempl/pru.sc: Likewise. * scripttempl/elf32msp430.sc: Likewise, and for other sections. * scripttempl/epiphany_4x4.sc: Similarly. --- ld/ChangeLog | 19 +++++++++++++++++++ ld/Makefile.am | 6 ++++-- ld/Makefile.in | 6 ++++-- ld/scripttempl/arclinux.sc | 4 ++-- ld/scripttempl/armbpabi.sc | 2 +- ld/scripttempl/avr.sc | 2 +- ld/scripttempl/elf.sc | 4 ++-- ld/scripttempl/elf32msp430.sc | 12 ++++++------ ld/scripttempl/elf64hppa.sc | 4 ++-- ld/scripttempl/elf_chaos.sc | 2 +- ld/scripttempl/elfarc.sc | 2 +- ld/scripttempl/elfxtensa.sc | 4 ++-- ld/scripttempl/epiphany_4x4.sc | 16 ++++++++-------- ld/scripttempl/mep.sc | 2 +- ld/scripttempl/nds32elf.sc | 4 ++-- ld/scripttempl/pru.sc | 4 ++-- 16 files changed, 58 insertions(+), 35 deletions(-) diff --git a/ld/ChangeLog b/ld/ChangeLog index b772dcdd5c3..4dfd2e82415 100644 --- a/ld/ChangeLog +++ b/ld/ChangeLog @@ -1,3 +1,22 @@ +2018-10-29 Alan Modra + + * Makefile.am (ei386beos.c, ei386go32.c): Correct dependencies. + * Makefile.in: Regenerate. + * scripttempl/elf.sc (.note.gnu.build-id, .eh_frame_hdr): Set + address with ${RELOCATING-0}. + * scripttempl/arclinux.sc: Likewise. + * scripttempl/armbpabi.sc: Likewise. + * scripttempl/avr.sc: Likewise. + * scripttempl/elf64hppa.sc: Likewise. + * scripttempl/elf_chaos.sc: Likewise. + * scripttempl/elfarc.sc: Likewise. + * scripttempl/elfxtensa.sc: Likewise. + * scripttempl/mep.sc: Likewise. + * scripttempl/nds32elf.sc: Likewise. + * scripttempl/pru.sc: Likewise. + * scripttempl/elf32msp430.sc: Likewise, and for other sections. + * scripttempl/epiphany_4x4.sc: Similarly. + 2018-10-26 Christoph Conrads * ld.texi (--gc-sections): Update. diff --git a/ld/Makefile.am b/ld/Makefile.am index 98ba096268f..7b4b49e762f 100644 --- a/ld/Makefile.am +++ b/ld/Makefile.am @@ -1382,13 +1382,15 @@ ehppaobsd.c: $(srcdir)/emulparams/hppaobsd.sh \ $(srcdir)/scripttempl/elf.sc ${GEN_DEPENDS} ei386beos.c: $(srcdir)/emulparams/i386beos.sh \ - $(srcdir)/emultempl/beos.em $(srcdir)/scripttempl/i386beos.sc ${GEN_DEPENDS} + $(srcdir)/emultempl/beos.em $(srcdir)/scripttempl/i386beos.sc \ + $(srcdir)/scripttempl/DWARF.sc ${GEN_DEPENDS} ei386bsd.c: $(srcdir)/emulparams/i386bsd.sh \ $(srcdir)/emultempl/generic.em $(srcdir)/scripttempl/aout.sc ${GEN_DEPENDS} ei386go32.c: $(srcdir)/emulparams/i386go32.sh \ - $(srcdir)/emultempl/generic.em $(srcdir)/scripttempl/i386go32.sc ${GEN_DEPENDS} + $(srcdir)/emultempl/generic.em $(srcdir)/scripttempl/i386go32.sc \ + $(srcdir)/scripttempl/DWARF.sc ${GEN_DEPENDS} ei386lynx.c: $(srcdir)/emulparams/i386lynx.sh \ $(ELF_DEPS) $(srcdir)/scripttempl/elf.sc ${GEN_DEPENDS} diff --git a/ld/Makefile.in b/ld/Makefile.in index e2fc6741536..9137cf3bd7b 100644 --- a/ld/Makefile.in +++ b/ld/Makefile.in @@ -2986,13 +2986,15 @@ ehppaobsd.c: $(srcdir)/emulparams/hppaobsd.sh \ $(srcdir)/scripttempl/elf.sc ${GEN_DEPENDS} ei386beos.c: $(srcdir)/emulparams/i386beos.sh \ - $(srcdir)/emultempl/beos.em $(srcdir)/scripttempl/i386beos.sc ${GEN_DEPENDS} + $(srcdir)/emultempl/beos.em $(srcdir)/scripttempl/i386beos.sc \ + $(srcdir)/scripttempl/DWARF.sc ${GEN_DEPENDS} ei386bsd.c: $(srcdir)/emulparams/i386bsd.sh \ $(srcdir)/emultempl/generic.em $(srcdir)/scripttempl/aout.sc ${GEN_DEPENDS} ei386go32.c: $(srcdir)/emulparams/i386go32.sh \ - $(srcdir)/emultempl/generic.em $(srcdir)/scripttempl/i386go32.sc ${GEN_DEPENDS} + $(srcdir)/emultempl/generic.em $(srcdir)/scripttempl/i386go32.sc \ + $(srcdir)/scripttempl/DWARF.sc ${GEN_DEPENDS} ei386lynx.c: $(srcdir)/emulparams/i386lynx.sh \ $(ELF_DEPS) $(srcdir)/scripttempl/elf.sc ${GEN_DEPENDS} diff --git a/ld/scripttempl/arclinux.sc b/ld/scripttempl/arclinux.sc index 931d7a54abf..2975864100e 100644 --- a/ld/scripttempl/arclinux.sc +++ b/ld/scripttempl/arclinux.sc @@ -358,7 +358,7 @@ emit_early_ro() { cat < text} - .rodata : + .rodata ${RELOCATING-0} : { ${RELOCATING+. = ALIGN(2); *(.lower.rodata.* .lower.rodata) @@ -239,7 +239,7 @@ SECTIONS KEEP (*(.dtors))} } ${RELOCATING+ > text} - .vectors ${RELOCATING-0}: + .vectors ${RELOCATING-0} : { ${RELOCATING+ PROVIDE (__vectors_start = .) ; } *(.vectors${RELOCATING+*}) @@ -277,7 +277,7 @@ SECTIONS ${RELOCATING+__romdatastart = LOADADDR(.data); __romdatacopysize = SIZEOF(.data);} - .bss ${RELOCATING+ SIZEOF(.data) + ADDR(.data)} : + .bss ${RELOCATING-0}${RELOCATING+SIZEOF(.data) + ADDR(.data)} : { ${RELOCATING+. = ALIGN(2);} ${RELOCATING+ PROVIDE (__bss_start = .); } @@ -291,14 +291,14 @@ SECTIONS } ${RELOCATING+ > data} ${RELOCATING+ PROVIDE (__bsssize = SIZEOF(.bss)); } - .noinit ${RELOCATING+ SIZEOF(.bss) + ADDR(.bss)} : + .noinit ${RELOCATING-0}${RELOCATING+SIZEOF(.bss) + ADDR(.bss)} : { ${RELOCATING+ PROVIDE (__noinit_start = .) ; } *(.noinit) ${RELOCATING+ PROVIDE (__noinit_end = .) ; } } ${RELOCATING+ > data} - .persistent ${RELOCATING+ SIZEOF(.noinit) + ADDR(.noinit)} : + .persistent ${RELOCATING-0}${RELOCATING+SIZEOF(.noinit) + ADDR(.noinit)} : { ${RELOCATING+ PROVIDE (__persistent_start = .) ; } *(.persistent) diff --git a/ld/scripttempl/elf64hppa.sc b/ld/scripttempl/elf64hppa.sc index 1bed6743c50..5496f3be7ad 100644 --- a/ld/scripttempl/elf64hppa.sc +++ b/ld/scripttempl/elf64hppa.sc @@ -299,7 +299,7 @@ SECTIONS ${CREATE_SHLIB+${RELOCATING+. = ${SHLIB_TEXT_START_ADDR} + SIZEOF_HEADERS;}} ${CREATE_PIE+${RELOCATING+. = ${SHLIB_TEXT_START_ADDR} + SIZEOF_HEADERS;}} ${INITIAL_READONLY_SECTIONS} - .note.gnu.build-id : { *(.note.gnu.build-id) } + .note.gnu.build-id ${RELOCATING-0}: { *(.note.gnu.build-id) } EOF test -n "${RELOCATING+0}" || unset NON_ALLOC_DYN @@ -431,7 +431,7 @@ cat < INTERNAL_RAM} */ =${NOP-0} - .text ${RELOCATING+ADDR(.fini)+SIZEOF(.fini)} ${RELOCATING-0} : + .text ${RELOCATING-0}${RELOCATING+ADDR(.fini)+SIZEOF(.fini)} : { ${RELOCATING+${TEXT_START_SYMBOLS}} *(.text .stub${RELOCATING+ .text.* .gnu.linkonce.t.*}) @@ -503,7 +503,7 @@ cat < dmem} /* Global data not cleared after reset. */ - .noinit ${RELOCATING-0}: + .noinit ${RELOCATING-0} : { ${RELOCATING+ PROVIDE (_noinit_start = .) ; } *(.noinit) @@ -185,7 +185,7 @@ SECTIONS .stab.index 0 : { *(.stab.index) } .stab.indexstr 0 : { *(.stab.indexstr) } .comment 0 : { *(.comment) } - .note.gnu.build-id : { *(.note.gnu.build-id) } + .note.gnu.build-id ${RELOCATING-0} : { *(.note.gnu.build-id) } EOF . $srcdir/scripttempl/DWARF.sc -- 2.30.2