From c2fa21f135a1293e90ab268a9317d29faa3ac47c Mon Sep 17 00:00:00 2001 From: Hui Zhu Date: Wed, 15 Jun 2011 14:40:22 +0000 Subject: [PATCH] 2011-06-15 Hui Zhu * remote.c (remote_trace_set_readonly_regions): Add a check for target_buf_size. --- gdb/ChangeLog | 5 +++++ gdb/remote.c | 13 +++++++++++-- 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 982eafc8fce..b40d0a6d136 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2011-06-15 Hui Zhu + + * remote.c (remote_trace_set_readonly_regions): Add a check for + target_buf_size. + 2011-06-14 Tom Tromey * coffread.c (coffread_objfile): Rename from current_objfile. diff --git a/gdb/remote.c b/gdb/remote.c index b60a89c6b20..e3079861795 100644 --- a/gdb/remote.c +++ b/gdb/remote.c @@ -9977,6 +9977,7 @@ remote_trace_set_readonly_regions (void) bfd_size_type size; bfd_vma vma; int anysecs = 0; + int offset = 0; if (!exec_bfd) return; /* No information to give. */ @@ -9985,6 +9986,7 @@ remote_trace_set_readonly_regions (void) for (s = exec_bfd->sections; s; s = s->next) { char tmp1[40], tmp2[40]; + int sec_length; if ((s->flags & SEC_LOAD) == 0 || /* (s->flags & SEC_CODE) == 0 || */ @@ -9996,8 +9998,15 @@ remote_trace_set_readonly_regions (void) size = bfd_get_section_size (s); sprintf_vma (tmp1, vma); sprintf_vma (tmp2, vma + size); - sprintf (target_buf + strlen (target_buf), - ":%s,%s", tmp1, tmp2); + sec_length = 1 + strlen (tmp1) + 1 + strlen (tmp2); + if (offset + sec_length + 1 > target_buf_size) + { + warning (_("\ +Too many sections for read-only sections definition packet.")); + break; + } + sprintf (target_buf + offset, ":%s,%s", tmp1, tmp2); + offset += sec_length; } if (anysecs) { -- 2.30.2