From c307d27c5e83c45d572b593de3497892c24dc178 Mon Sep 17 00:00:00 2001 From: Francisco Jerez Date: Fri, 20 Sep 2013 16:36:37 -0700 Subject: [PATCH] i965: Switch fs_live_variables to the non-zeroing allocator. All member variables of fs_live_variables are already being initialized from its constructor, it's not necessary to use rzalloc to allocate its memory, and doing so makes it more likely that we will start relying on the allocator to zero out all memory if the class is ever extended with new member variables. That's bad because it ties objects to some specific allocation scheme, and gives unpredictable results when an object is created with a different allocator -- Stack allocation, array allocation, or aggregation inside a different object are some of the useful possibilities that come to my mind. Reviewed-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_fs_live_variables.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_live_variables.h b/src/mesa/drivers/dri/i965/brw_fs_live_variables.h index fa8b61d0ae3..e2274391541 100644 --- a/src/mesa/drivers/dri/i965/brw_fs_live_variables.h +++ b/src/mesa/drivers/dri/i965/brw_fs_live_variables.h @@ -53,7 +53,7 @@ struct block_data { class fs_live_variables { public: - DECLARE_RZALLOC_CXX_OPERATORS(fs_live_variables) + DECLARE_RALLOC_CXX_OPERATORS(fs_live_variables) fs_live_variables(fs_visitor *v, cfg_t *cfg); ~fs_live_variables(); -- 2.30.2