From c428c220fd351626e2ee0005dda696940261793b Mon Sep 17 00:00:00 2001 From: Ciro Santilli Date: Fri, 31 Aug 2018 11:39:19 +0100 Subject: [PATCH] scons: remove as version check GNU as 2.31.1 checks if the input and output files are the same: Assembler messages: Fatal error: The input and output files must be distinct The check already does not work for llvm-as which has a different output format. Since it is too hard to maintain the check correctly for all possible assemblers, it is better to just remove it completely. Change-Id: I38a993ab83ca83d4a2f5e77820d2ca903f70c6ac Reviewed-on: https://gem5-review.googlesource.com/12403 Reviewed-by: Jason Lowe-Power Reviewed-by: Andreas Sandberg Maintainer: Andreas Sandberg --- SConstruct | 21 --------------------- 1 file changed, 21 deletions(-) diff --git a/SConstruct b/SConstruct index f689b556a..d81c5abd9 100755 --- a/SConstruct +++ b/SConstruct @@ -421,27 +421,6 @@ if main['GCC']: main.Append(PSHLINKFLAGS='-flinker-output=rel') main.Append(PLINKFLAGS='-flinker-output=rel') - # gcc from version 4.8 and above generates "rep; ret" instructions - # to avoid performance penalties on certain AMD chips. Older - # assemblers detect this as an error, "Error: expecting string - # instruction after `rep'" - as_version_raw = readCommand([main['AS'], '-v', '/dev/null', - '-o', '/dev/null'], - exception=False).split() - - # version strings may contain extra distro-specific - # qualifiers, so play it safe and keep only what comes before - # the first hyphen - as_version = as_version_raw[-1].split('-')[0] if as_version_raw else None - - if not as_version or compareVersions(as_version, "2.23") < 0: - print(termcap.Yellow + termcap.Bold + - 'Warning: This combination of gcc and binutils have' + - ' known incompatibilities.\n' + - ' If you encounter build problems, please update ' + - 'binutils to 2.23.' + - termcap.Normal) - # Make sure we warn if the user has requested to compile with the # Undefined Benahvior Sanitizer and this version of gcc does not # support it. -- 2.30.2