From c42bd95ac2827f22c134f13752c44ecc69d153f7 Mon Sep 17 00:00:00 2001 From: Doug Evans Date: Tue, 12 Nov 2013 21:40:41 -0800 Subject: [PATCH] * breakpoint.c (breakpoint_cond_eval): Fix and enhance comment. --- gdb/ChangeLog | 4 ++++ gdb/breakpoint.c | 8 +++++--- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 15722499bc3..c86f25de232 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,7 @@ +2013-11-13 Doug Evans + + * breakpoint.c (breakpoint_cond_eval): Fix and enhance comment. + 2013-11-13 Joel Brobecker * mi/mi-main.c (mi_cmd_list_features): Replace "info-ada-exceptions" diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c index 36252ee5423..f0b496d7080 100644 --- a/gdb/breakpoint.c +++ b/gdb/breakpoint.c @@ -4649,10 +4649,12 @@ bpstat_print (bpstat bs, int kind) return PRINT_UNKNOWN; } -/* Evaluate the expression EXP and return 1 if value is zero. This is - used inside a catch_errors to evaluate the breakpoint condition. +/* Evaluate the expression EXP and return 1 if value is zero. + This returns the inverse of the condition because it is called + from catch_errors which returns 0 if an exception happened, and if an + exception happens we want execution to stop. The argument is a "struct expression *" that has been cast to a - "char *" to make it pass through catch_errors. */ + "void *" to make it pass through catch_errors. */ static int breakpoint_cond_eval (void *exp) -- 2.30.2