From c4cad07fc524f7b1362ab98d66e961ad80a8587c Mon Sep 17 00:00:00 2001 From: Gabe Black Date: Sun, 24 Jan 2021 22:38:40 -0800 Subject: [PATCH] base: Make the default checkBpLen method return true. This was checking that the breakpoint length was equal to the length of the ISA specific MachInst type. Instead, force the ISA specific remote GDB subclass to implement a check if it wants to, specific to its needs. The base implementation will just approve of any length, which should be fine with a well behaved GDB client. Change-Id: Id7325b788f8445049855f8104082b8e4da1fe300 Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/39661 Reviewed-by: Daniel Carvalho Reviewed-by: Bobby R. Bruce Maintainer: Bobby R. Bruce Tested-by: kokoro --- src/base/remote_gdb.cc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/base/remote_gdb.cc b/src/base/remote_gdb.cc index 02cb11ad5..bde1acf77 100644 --- a/src/base/remote_gdb.cc +++ b/src/base/remote_gdb.cc @@ -141,7 +141,6 @@ #include "base/intmath.hh" #include "base/socket.hh" #include "base/trace.hh" -#include "config/the_isa.hh" #include "cpu/base.hh" #include "cpu/static_inst.hh" #include "cpu/thread_context.hh" @@ -786,7 +785,7 @@ std::map BaseRemoteGDB::command_map = { bool BaseRemoteGDB::checkBpLen(size_t len) { - return len == sizeof(TheISA::MachInst); + return true; } bool -- 2.30.2