From c596f180a130c85faf8942d161be9ecf71c6791c Mon Sep 17 00:00:00 2001 From: Tom de Vries Date: Fri, 21 Jun 2019 23:56:18 +0200 Subject: [PATCH] [gdb/testsuite] Compile index-cache.c with -Wl,--build-id When testing gdb.base/index-cache.exp using a gcc build without --enable-linker-build-id we get: ... FAIL: gdb.base/index-cache.exp: \ test_cache_enabled_miss: at least one file was created FAIL: gdb.base/index-cache.exp: \ test_cache_enabled_miss: couldn't get executable build id FAIL: gdb.base/index-cache.exp: \ test_cache_enabled_hit: check index-cache stats ... With "set debug index-cache on" we find: ... (gdb) file index-cache Reading symbols from index-cache... index cache: objfile index-cache has no build id ... The problem is that a build-id is required for the index-cache functionality. Fix this by compiling index-cache.c with -Wl,--build-id. Tested on x86_64-linux. gdb/testsuite/ChangeLog: 2019-06-21 Tom de Vries * gdb.base/index-cache.exp: Add additional_flags=-Wl,--build-id. --- gdb/testsuite/ChangeLog | 4 ++++ gdb/testsuite/gdb.base/index-cache.exp | 3 ++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index d4e7d8b6707..8cd3c511941 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,7 @@ +2019-06-21 Tom de Vries + + * gdb.base/index-cache.exp: Add additional_flags=-Wl,--build-id. + 2019-06-21 Tom de Vries PR testsuite/24518 diff --git a/gdb/testsuite/gdb.base/index-cache.exp b/gdb/testsuite/gdb.base/index-cache.exp index 075dffe3f5e..6f1488e0371 100644 --- a/gdb/testsuite/gdb.base/index-cache.exp +++ b/gdb/testsuite/gdb.base/index-cache.exp @@ -18,7 +18,8 @@ standard_testfile -if { [prepare_for_testing "failed to prepare" $testfile $srcfile] } { +if { [prepare_for_testing "failed to prepare" $testfile $srcfile \ + {additional_flags=-Wl,--build-id}] } { return } -- 2.30.2