From c5ddaa2cd71c100fe4aa6da36b6ac1a59e6665e3 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Kristian=20H=C3=B8gsberg?= Date: Fri, 28 May 2010 15:50:11 -0400 Subject: [PATCH] egl_dri2: Check for xcb_connect() failure the right way It always returns a valid xcb_connection_t, but if connection failed, it's in the error state. --- src/egl/drivers/dri2/egl_dri2.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/drivers/dri2/egl_dri2.c index eb9a6510ed0..a9c9b986cc5 100644 --- a/src/egl/drivers/dri2/egl_dri2.c +++ b/src/egl/drivers/dri2/egl_dri2.c @@ -647,16 +647,14 @@ dri2_initialize(_EGLDriver *drv, _EGLDisplay *disp, disp->DriverData = (void *) dri2_dpy; if (disp->NativeDisplay == NULL) { dri2_dpy->conn = xcb_connect(0, 0); - if (!dri2_dpy->conn) { - _eglLog(_EGL_WARNING, "DRI2: xcb_connect failed"); - goto cleanup_dpy; - } } else { dri2_dpy->conn = XGetXCBConnection(disp->NativeDisplay); } - if (dri2_dpy->conn == NULL) - goto cleanup_conn; + if (xcb_connection_has_error(dri2_dpy->conn)) { + _eglLog(_EGL_WARNING, "DRI2: xcb_connect failed"); + goto cleanup_dpy; + } if (dri2_dpy->conn) { if (!dri2_connect(dri2_dpy)) -- 2.30.2