From c5e71b3332279ece95a7872aee2890af3ee047b4 Mon Sep 17 00:00:00 2001 From: Tom de Vries Date: Mon, 4 Jan 2021 16:48:48 +0100 Subject: [PATCH] [gdb/testsuite] Don't require gold for gdb.base/morestack.exp While working on PR26935 I noticed that the test-case requires the gold linker, but doesn't really need it. The -fuse-ld=gold was added to support the printf in the test-case, which prints some information but is not otherwise needed for the test-case. Fix this by removing the printf and the corresponding -fuse-ld=gold. Tested on x86_64-linux. Also checked that the test still fails when the fix from the commit that added the test-case is reverted. gdb/testsuite/ChangeLog: 2021-01-04 Tom de Vries * gdb.base/morestack.c: Remove printf. * gdb.base/morestack.exp: Don't use -fuse-ld=gold. --- gdb/testsuite/ChangeLog | 5 +++++ gdb/testsuite/gdb.base/morestack.c | 5 +---- gdb/testsuite/gdb.base/morestack.exp | 8 +------- 3 files changed, 7 insertions(+), 11 deletions(-) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 0074c8fb6f0..36644bb1e47 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2021-01-04 Tom de Vries + + * gdb.base/morestack.c: Remove printf. + * gdb.base/morestack.exp: Don't use -fuse-ld=gold. + 2020-12-31 Tom Tromey * gdb.rust/simple.exp: Update output for Rust 1.49. diff --git a/gdb/testsuite/gdb.base/morestack.c b/gdb/testsuite/gdb.base/morestack.c index 6f9a27ed2c8..78ab3db93f9 100644 --- a/gdb/testsuite/gdb.base/morestack.c +++ b/gdb/testsuite/gdb.base/morestack.c @@ -62,10 +62,7 @@ down (int i) static void *last; if (last && last < (void *) buf) - { - printf ("%d: %p < %p\n", i, last, buf); - marker_hit (); - } + marker_hit (); last = buf; if (i == 500) diff --git a/gdb/testsuite/gdb.base/morestack.exp b/gdb/testsuite/gdb.base/morestack.exp index 627ae8164c3..99807a291ee 100644 --- a/gdb/testsuite/gdb.base/morestack.exp +++ b/gdb/testsuite/gdb.base/morestack.exp @@ -21,17 +21,11 @@ if {$gcc_compiled == 0} { return -1 } -if { [have_fuse_ld_gold] == 0} { - return -1 -} - standard_testfile -# -fuse-ld=gold is used for calling printf code built without -fsplit-stack -# which could crash otherwise. See GCC documentation of -fsplit-stack. set opts "additional_flags=-fsplit-stack" if { [prepare_for_testing "failed to prepare" ${testfile} $srcfile \ - [list $opts additional_flags=-fuse-ld=gold]] } { + [list $opts]] } { return -1 } -- 2.30.2