From c614884730f1251a2fba98c1761053d2598efd38 Mon Sep 17 00:00:00 2001 From: Colin Didier Date: Thu, 19 Jun 2014 18:13:37 +0200 Subject: [PATCH] devmem2: fix output when _FILE_OFFSET_BITS=64 When built with _FILE_OFFSET_BITS=64, off_t becomes an long long int and was printed as an unsigned int which lead to a garbled output. Signed-off-by: Colin Didier Signed-off-by: Maxime Hadjinlian Signed-off-by: Thomas Petazzoni --- ...vmem2-0001-be-coherent-in-type-usage.patch | 49 +++++++++++++++++++ 1 file changed, 49 insertions(+) create mode 100644 package/devmem2/devmem2-0001-be-coherent-in-type-usage.patch diff --git a/package/devmem2/devmem2-0001-be-coherent-in-type-usage.patch b/package/devmem2/devmem2-0001-be-coherent-in-type-usage.patch new file mode 100644 index 0000000000..541ac6eb89 --- /dev/null +++ b/package/devmem2/devmem2-0001-be-coherent-in-type-usage.patch @@ -0,0 +1,49 @@ +From 15eae3dbb3d6824a0fd478e2ce0fe879496bb72c Mon Sep 17 00:00:00 2001 +From: Colin Didier +Date: Thu, 19 Jun 2014 16:58:19 +0200 +Subject: [PATCH] be coherent in type usage + +- no need to use off_t because it is read from strtoul() +- print unsigned int type correctly + +When built with _FILE_OFFSET_BITS=64, off_t becomes an long long int +and was printed as an unsigned int which lead to a garbled output. + +Signed-off-by: Colin Didier +--- + devmem2.c | 7 +++---- + 1 file changed, 3 insertions(+), 4 deletions(-) + +diff --git a/devmem2.c b/devmem2.c +index 7732ecb..1ae06ef 100644 +--- a/devmem2.c ++++ b/devmem2.c +@@ -58,8 +58,7 @@ + int main(int argc, char **argv) { + int fd; + void *map_base, *virt_addr; +- unsigned long read_result, writeval; +- off_t target; ++ unsigned long target, read_result, writeval; + int access_type = 'w'; + + if(argc < 2) { +@@ -101,7 +100,7 @@ int main(int argc, char **argv) { + fprintf(stderr, "Illegal data type '%c'.\n", access_type); + exit(2); + } +- printf("Value at address 0x%X (%p): 0x%X\n", target, virt_addr, read_result); ++ printf("Value at address 0x%lX (%p): 0x%lX\n", target, virt_addr, read_result); + fflush(stdout); + + if(argc > 3) { +@@ -120,7 +119,7 @@ int main(int argc, char **argv) { + read_result = *((unsigned long *) virt_addr); + break; + } +- printf("Written 0x%X; readback 0x%X\n", writeval, read_result); ++ printf("Written 0x%lX; readback 0x%lX\n", writeval, read_result); + fflush(stdout); + } + +-- -- 2.30.2