From c658158d936f25dca30cc89260168a5c0be3a24c Mon Sep 17 00:00:00 2001 From: Pedro Alves Date: Wed, 19 Feb 2014 18:25:41 +0000 Subject: [PATCH] common/ptid.h: Mention that process_stratum targets should prefer ptid.lwp. It's best that we standardize on process_stratum targets using the ptid.lwp field to store thread ids. The idea being leave the ptid.tid field free for any thread_stratum target that might want to sit on top. This patch adds a comment in that direction to struct ptid's definition. gdb/ 2014-02-19 Pedro Alves * common/ptid.h (struct ptid): Mention that process_stratum targets should prefer ptid.lwp. --- gdb/ChangeLog | 5 +++++ gdb/common/ptid.h | 7 ++++++- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 122288dbf7d..f8779b08f6b 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2014-02-19 Pedro Alves + + * common/ptid.h (struct ptid): Mention that process_stratum + targets should prefer ptid.lwp. + 2014-02-19 Pedro Alves * remote.c (remote_thread_alive, write_ptid, read_ptid) diff --git a/gdb/common/ptid.h b/gdb/common/ptid.h index 362882dfa3e..cc1825e9bef 100644 --- a/gdb/common/ptid.h +++ b/gdb/common/ptid.h @@ -25,7 +25,12 @@ consists of the process id (pid), lightweight process id (lwp) and thread id (tid). When manipulating ptids, the constructors, accessors, and predicates declared in this file should be used. Do - NOT access the struct ptid members directly. */ + NOT access the struct ptid members directly. + + process_stratum targets that handle threading themselves should + prefer using the ptid.lwp field, leaving the ptid.tid field for any + thread_stratum target that might want to sit on top. +*/ struct ptid { -- 2.30.2