From c6e8e93a865d429546037cf5746502aa253a1f2d Mon Sep 17 00:00:00 2001 From: Nick Clifton Date: Fri, 9 Jan 2015 21:56:30 +0000 Subject: [PATCH] Fixes a bug in the previous delat to tekhex.c which meant that valid tekhex files were being rejected. * tekhex.c (getvalue): Fix thinko in test for correct extraction of value. (getsym): Return false if there was not enough data to extract the symbol. --- bfd/ChangeLog | 7 +++++++ bfd/tekhex.c | 4 ++-- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/bfd/ChangeLog b/bfd/ChangeLog index 1bc66e419a7..70b138b2d05 100644 --- a/bfd/ChangeLog +++ b/bfd/ChangeLog @@ -1,3 +1,10 @@ +2015-01-09 Nick Clifton + + * tekhex.c (getvalue): Fix thinko in test for correct extraction + of value. + (getsym): Return false if there was not enough data to extract the + symbol. + 2015-01-09 Anthony Green * elf32-moxie.c (ELF_MACHINE_ALT1): Define. diff --git a/bfd/tekhex.c b/bfd/tekhex.c index 9444117e5ff..94b47739f56 100644 --- a/bfd/tekhex.c +++ b/bfd/tekhex.c @@ -288,7 +288,7 @@ getvalue (char **srcp, bfd_vma *valuep, char * endp) *srcp = src; *valuep = value; - return len == 0; + return len == -1U; } static bfd_boolean @@ -309,7 +309,7 @@ getsym (char *dstp, char **srcp, unsigned int *lenp, char * endp) dstp[i] = 0; *srcp = src + i; *lenp = len; - return TRUE; + return i == len; } static struct data_struct * -- 2.30.2