From c7170e974234d5c5bd1a6f5f7b2f76ef5acc44c1 Mon Sep 17 00:00:00 2001 From: Alyssa Rosenzweig Date: Fri, 27 Mar 2020 20:11:07 -0400 Subject: [PATCH] pan/bi: Assert out i16 related converts for now Needs more investigation, and GLSL doesn't use it quite yet sadly. Signed-off-by: Alyssa Rosenzweig Part-of: --- src/panfrost/bifrost/bi_pack.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/panfrost/bifrost/bi_pack.c b/src/panfrost/bifrost/bi_pack.c index c53b40fe2b4..f60efd9ad19 100644 --- a/src/panfrost/bifrost/bi_pack.c +++ b/src/panfrost/bifrost/bi_pack.c @@ -621,6 +621,7 @@ bi_pack_fma_convert(bi_instruction *ins, struct bi_registers *regs) if (from_size == 16 && to_size == 16) { /* f2i_i2f16 */ + unreachable("i16 not yet implemented"); } else if (from_size == 32 && to_size == 32) { unsigned op = 0; @@ -638,7 +639,7 @@ bi_pack_fma_convert(bi_instruction *ins, struct bi_registers *regs) return bi_pack_fma_1src(ins, regs, BIFROST_FMA_FLOAT16_TO_32(from_y)); } else { - /* int16_to_32 */ + unreachable("i16 not yet implemented"); } } else if (from_size == 32 && to_size == 16) { if (from_base == nir_type_float) { @@ -651,11 +652,11 @@ bi_pack_fma_convert(bi_instruction *ins, struct bi_registers *regs) RETURN_PACKED(pack); } else { - /* XXX: No int32_to_int16? */ + unreachable("i16 not yet implemented"); } } - return BIFROST_FMA_NOP; + unreachable("Unknown convert"); } static unsigned -- 2.30.2