From c78d2d98409200f0b40d2e7bb7d143afbf1f0895 Mon Sep 17 00:00:00 2001 From: Eric Engestrom Date: Thu, 11 Oct 2018 18:38:52 +0100 Subject: [PATCH] egl: add glvnd symbols check According to the spec [1], `__egl_Main` is the only symbol that needs to be exported. We don't want applications directly linking against libEGL_mesa.so (apps should always go through libEGL.so, regardless of who is providing it), so we shouldn't export any other symbols either. [1] https://github.com/NVIDIA/libglvnd/blob/master/include/glvnd/libeglabi.h (this header is the closest there is to a spec) Signed-off-by: Eric Engestrom Reviewed-by: Emil Velikov --- src/egl/egl-glvnd-symbols.txt | 1 + src/egl/meson.build | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) create mode 100644 src/egl/egl-glvnd-symbols.txt diff --git a/src/egl/egl-glvnd-symbols.txt b/src/egl/egl-glvnd-symbols.txt new file mode 100644 index 00000000000..40d931edcf9 --- /dev/null +++ b/src/egl/egl-glvnd-symbols.txt @@ -0,0 +1 @@ +__egl_Main diff --git a/src/egl/meson.build b/src/egl/meson.build index 019f79ee212..d864c099efa 100644 --- a/src/egl/meson.build +++ b/src/egl/meson.build @@ -194,7 +194,7 @@ pkg.generate( if with_tests and prog_nm.found() if with_glvnd - # TODO: add glvnd symbol check + egl_symbols = files('egl-glvnd-symbols.txt') else egl_symbols = files('egl-symbols.txt') endif -- 2.30.2