From c7a09c057162ed0b7e9e039470c76bb79518876c Mon Sep 17 00:00:00 2001 From: Jason Ekstrand Date: Fri, 9 Oct 2015 18:07:23 -0700 Subject: [PATCH] i965/fs: Properly report regs_written from SAMPLEINFO The previous behavior would only allocate one register and then write four thus potentially stomping three innocent bystanders. Cc: mesa-stable@lists.freedesktop.org Reviewed-by: Kenneth Graunke Reviewed-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 8 +++++++- src/mesa/drivers/dri/i965/brw_shader.cpp | 3 ++- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp index 725f5dac0c7..43d37453425 100644 --- a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp +++ b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp @@ -3205,12 +3205,18 @@ fs_visitor::nir_emit_texture(const fs_builder &bld, nir_tex_instr *instr) case nir_texop_txs: op = ir_txs; break; case nir_texop_texture_samples: { fs_reg dst = retype(get_nir_dest(instr->dest), BRW_REGISTER_TYPE_D); - fs_inst *inst = bld.emit(SHADER_OPCODE_SAMPLEINFO, dst, + + fs_reg tmp = bld.vgrf(BRW_REGISTER_TYPE_D, 4); + fs_inst *inst = bld.emit(SHADER_OPCODE_SAMPLEINFO, tmp, bld.vgrf(BRW_REGISTER_TYPE_D, 1), texture_reg, texture_reg); inst->mlen = 1; inst->header_size = 1; inst->base_mrf = -1; + inst->regs_written = 4 * (dispatch_width / 8); + + /* Pick off the one component we care about */ + bld.MOV(dst, tmp); return; } case nir_texop_samples_identical: op = ir_samples_identical; break; diff --git a/src/mesa/drivers/dri/i965/brw_shader.cpp b/src/mesa/drivers/dri/i965/brw_shader.cpp index d9e654c4d4f..80fddfc1bd4 100644 --- a/src/mesa/drivers/dri/i965/brw_shader.cpp +++ b/src/mesa/drivers/dri/i965/brw_shader.cpp @@ -757,7 +757,8 @@ backend_instruction::is_tex() const opcode == SHADER_OPCODE_TXS || opcode == SHADER_OPCODE_LOD || opcode == SHADER_OPCODE_TG4 || - opcode == SHADER_OPCODE_TG4_OFFSET); + opcode == SHADER_OPCODE_TG4_OFFSET || + opcode == SHADER_OPCODE_SAMPLEINFO); } bool -- 2.30.2