From c865b6c94dcf9a67b241306bf474b66a19ec6928 Mon Sep 17 00:00:00 2001 From: Luke Kenneth Casson Leighton Date: Thu, 1 Sep 2022 23:56:59 +0100 Subject: [PATCH] ghostmansd found that extswsli is incorrectly declared as extswsli RA,RS,SH as XS-Form, where a quick check shows that there *is* no field "SH" in XS-Form. there *is* however a field "sh" in XS-Form and the pseudocode *correctly* uses it. that then led to a review of all the other uses of SH and sh, which also led to spotting that ME and MB are *also* mis-used (MD-Form and MDS-Form) and need lower-casing in the operand declaration but are *also* correct in the pseudo-code ` --- openpower/isa/fixedshift.mdwn | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/openpower/isa/fixedshift.mdwn b/openpower/isa/fixedshift.mdwn index 02f1a71a..fd88c1a3 100644 --- a/openpower/isa/fixedshift.mdwn +++ b/openpower/isa/fixedshift.mdwn @@ -68,8 +68,8 @@ Special Registers Altered: MD-Form -* rldicl RA,RS,SH,MB (Rc=0) -* rldicl. RA,RS,SH,MB (Rc=1) +* rldicl RA,RS,sh,mb (Rc=0) +* rldicl. RA,RS,sh,mb (Rc=1) Pseudo-code: @@ -87,8 +87,8 @@ Special Registers Altered: MD-Form -* rldicr RA,RS,SH,ME (Rc=0) -* rldicr. RA,RS,SH,ME (Rc=1) +* rldicr RA,RS,sh,me (Rc=0) +* rldicr. RA,RS,sh,me (Rc=1) Pseudo-code: @@ -106,8 +106,8 @@ Special Registers Altered: MD-Form -* rldic RA,RS,SH,MB (Rc=0) -* rldic. RA,RS,SH,MB (Rc=1) +* rldic RA,RS,sh,mb (Rc=0) +* rldic. RA,RS,sh,mb (Rc=1) Pseudo-code: @@ -125,8 +125,8 @@ Special Registers Altered: MDS-Form -* rldcl RA,RS,RB,MB (Rc=0) -* rldcl. RA,RS,RB,MB (Rc=1) +* rldcl RA,RS,RB,mb (Rc=0) +* rldcl. RA,RS,RB,mb (Rc=1) Pseudo-code: @@ -144,8 +144,8 @@ Special Registers Altered: MDS-Form -* rldcr RA,RS,RB,ME (Rc=0) -* rldcr. RA,RS,RB,ME (Rc=1) +* rldcr RA,RS,RB,me (Rc=0) +* rldcr. RA,RS,RB,me (Rc=1) Pseudo-code: @@ -163,8 +163,8 @@ Special Registers Altered: MD-Form -* rldimi RA,RS,SH,MB (Rc=0) -* rldimi. RA,RS,SH,MB (Rc=1) +* rldimi RA,RS,sh,mb (Rc=0) +* rldimi. RA,RS,sh,mb (Rc=1) Pseudo-code: @@ -313,8 +313,8 @@ Special Registers Altered: XS-Form -* sradi RA,RS,SH (Rc=0) -* sradi. RA,RS,SH (Rc=1) +* sradi RA,RS,sh (Rc=0) +* sradi. RA,RS,sh (Rc=1) Pseudo-code: @@ -361,8 +361,8 @@ Special Registers Altered: XS-Form -* extswsli RA,RS,SH (Rc=0) -* extswsli. RA,RS,SH (Rc=1) +* extswsli RA,RS,sh (Rc=0) +* extswsli. RA,RS,sh (Rc=1) Pseudo-code: -- 2.30.2