From c8acbd1bfdafa892e6c5e9a6d9100aa2e69b9096 Mon Sep 17 00:00:00 2001 From: Matt Turner Date: Tue, 17 Mar 2015 23:27:38 -0700 Subject: [PATCH] glsl: Allow vector logic ops to be generated. They're not accessible from the source language, but optimizations are allowed to generate them. Reviewed-by: Ian Romanick --- src/glsl/ir_validate.cpp | 6 +++--- src/mesa/drivers/dri/i965/brw_fs_channel_expressions.cpp | 9 +++------ 2 files changed, 6 insertions(+), 9 deletions(-) diff --git a/src/glsl/ir_validate.cpp b/src/glsl/ir_validate.cpp index 7a7688cb23b..72c5f061c20 100644 --- a/src/glsl/ir_validate.cpp +++ b/src/glsl/ir_validate.cpp @@ -543,9 +543,9 @@ ir_validate::visit_leave(ir_expression *ir) case ir_binop_logic_and: case ir_binop_logic_xor: case ir_binop_logic_or: - assert(ir->type == glsl_type::bool_type); - assert(ir->operands[0]->type == glsl_type::bool_type); - assert(ir->operands[1]->type == glsl_type::bool_type); + assert(ir->type->base_type == GLSL_TYPE_BOOL); + assert(ir->operands[0]->type->base_type == GLSL_TYPE_BOOL); + assert(ir->operands[1]->type->base_type == GLSL_TYPE_BOOL); break; case ir_binop_dot: diff --git a/src/mesa/drivers/dri/i965/brw_fs_channel_expressions.cpp b/src/mesa/drivers/dri/i965/brw_fs_channel_expressions.cpp index 933fdde24f9..4049b09797c 100644 --- a/src/mesa/drivers/dri/i965/brw_fs_channel_expressions.cpp +++ b/src/mesa/drivers/dri/i965/brw_fs_channel_expressions.cpp @@ -271,6 +271,9 @@ ir_channel_expressions_visitor::visit_leave(ir_assignment *ir) case ir_binop_bit_and: case ir_binop_bit_xor: case ir_binop_bit_or: + case ir_binop_logic_and: + case ir_binop_logic_xor: + case ir_binop_logic_or: case ir_binop_less: case ir_binop_greater: case ir_binop_lequal: @@ -329,12 +332,6 @@ ir_channel_expressions_visitor::visit_leave(ir_assignment *ir) break; } - case ir_binop_logic_and: - case ir_binop_logic_xor: - case ir_binop_logic_or: - ir->fprint(stderr); - fprintf(stderr, "\n"); - unreachable("not reached: expression operates on scalars only"); case ir_binop_all_equal: case ir_binop_any_nequal: { ir_expression *last = NULL; -- 2.30.2