From c9761be54f3d24f3a9f2bece75c8286db641fd41 Mon Sep 17 00:00:00 2001
From: Florent Kermarrec <florent@enjoy-digital.fr>
Date: Thu, 22 Jan 2015 00:23:11 +0100
Subject: [PATCH] command: remove success/failed redundancy (keep failed)

---
 litesata/common.py                | 2 --
 litesata/core/command/__init__.py | 3 ---
 litesata/test/command_tb.py       | 2 --
 targets/bist.py                   | 1 -
 4 files changed, 8 deletions(-)

diff --git a/litesata/common.py b/litesata/common.py
index 235c9065..18f5603c 100644
--- a/litesata/common.py
+++ b/litesata/common.py
@@ -214,7 +214,6 @@ def command_rx_description(dw):
 		("read", 1),
 		("identify", 1),
 		("last", 1),
-		("success", 1),
 		("failed", 1),
 		("data", dw)
 	]
@@ -226,7 +225,6 @@ def command_rx_cmd_description(dw):
 		("read", 1),
 		("identify", 1),
 		("last", 1),
-		("success", 1),
 		("failed", 1)
 	]
 	return EndpointDescription(layout, packetized=False)
diff --git a/litesata/core/command/__init__.py b/litesata/core/command/__init__.py
index f614415b..3a330839 100644
--- a/litesata/core/command/__init__.py
+++ b/litesata/core/command/__init__.py
@@ -192,7 +192,6 @@ class LiteSATACommandRX(Module):
 			source.eop.eq(1),
 			source.write.eq(1),
 			source.last.eq(1),
-			source.success.eq(~transport.source.error & ~d2h_error),
 			source.failed.eq(transport.source.error | d2h_error),
 			If(source.stb & source.ack,
 				NextState("IDLE")
@@ -232,7 +231,6 @@ class LiteSATACommandRX(Module):
 			source.eop.eq(transport.source.eop),
 			source.read.eq(~is_identify),
 			source.identify.eq(is_identify),
-			source.success.eq(~transport.source.error),
 			source.failed.eq(transport.source.error),
 			source.last.eq(is_identify),
 			source.data.eq(transport.source.data),
@@ -255,7 +253,6 @@ class LiteSATACommandRX(Module):
 			source.eop.eq(1),
 			source.read.eq(1),
 			source.last.eq(1),
-			source.success.eq(read_done & ~read_error & ~d2h_error),
 			source.failed.eq(~read_done | read_error | d2h_error),
 			If(source.stb & source.ack,
 				NextState("IDLE")
diff --git a/litesata/test/command_tb.py b/litesata/test/command_tb.py
index 0b9d53a0..566902fd 100644
--- a/litesata/test/command_tb.py
+++ b/litesata/test/command_tb.py
@@ -32,7 +32,6 @@ class CommandRXPacket(list):
 		self.done = False
 		self.write = 0
 		self.read = 0
-		self.success = 0
 		self.failed = 0
 
 class CommandLogger(PacketLogger):
@@ -45,7 +44,6 @@ class CommandLogger(PacketLogger):
 			self.packet = CommandRXPacket()
 			self.packet.write = selfp.sink.write
 			self.packet.read = selfp.sink.read
-			self.packet.sucess = selfp.sink.success
 			self.packet.failed = selfp.sink.failed
 			self.packet.append(selfp.sink.data)
 		elif selfp.sink.stb:
diff --git a/targets/bist.py b/targets/bist.py
index 29581b28..717ae7b1 100644
--- a/targets/bist.py
+++ b/targets/bist.py
@@ -187,7 +187,6 @@ class BISTSoCDevel(BISTSoC, AutoCSR):
 			self.sata.core.command.source.write,
 			self.sata.core.command.source.read,
 			self.sata.core.command.source.identify,
-			self.sata.core.command.source.success,
 			self.sata.core.command.source.failed,
 			self.sata.core.command.source.data,
 
-- 
2.30.2