From c9922a4d2fc79e1d17f85e6f74c1e6ece9c91092 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Stefan=20S=C3=B8rensen?= Date: Mon, 7 May 2018 14:28:43 +0200 Subject: [PATCH] dropbear: Do not build static binary MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Dropbear 2018.76 now uses the --enable-static option to indicate that a static binary should be built. This will incorrectly pick up the generic buildroot option intended for building static libraries, causing an unwanted static binary build with BR2_SHARED_STATIC_LIBS. Fix by appending an --disable-static configure flag, overriding the buildroot default. Signed-off-by: Stefan Sørensen Reviewed-by: Baruch Siach Signed-off-by: Thomas Petazzoni --- package/dropbear/dropbear.mk | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/package/dropbear/dropbear.mk b/package/dropbear/dropbear.mk index 1da1a559a3..fc41a84c1f 100644 --- a/package/dropbear/dropbear.mk +++ b/package/dropbear/dropbear.mk @@ -27,8 +27,11 @@ DROPBEAR_MAKE = \ $(MAKE) MULTI=1 SCPPROGRESS=1 \ PROGRAMS="$(DROPBEAR_PROGRAMS)" -ifeq ($(BR2_STATIC_LIBS),y) -DROPBEAR_CONF_OPTS += --enable-static +# With BR2_SHARED_STATIC_LIBS=y the generic infrastructure adds a +# --enable-static flags causing dropbear to be built as a static +# binary. Adding a --disable-static reverts this +ifeq ($(BR2_SHARED_STATIC_LIBS),y) +DROPBEAR_CONF_OPTS += --disable-static endif # Ensure that dropbear doesn't use crypt() when it's not available -- 2.30.2