From caaf2272c0eeb365b2c98d60f3ecf8f8f78cdb1f Mon Sep 17 00:00:00 2001 From: Jakub Jelinek Date: Wed, 6 Feb 2002 20:37:31 +0100 Subject: [PATCH] re PR c/5420 (bad code generated with gcc3.1/ia64) PR c/5420: * c-common.c (c_unsafe_for_reeval): Make COMPOUND_LITERAL_EXPR unsafe for reevaluation. * gcc.c-torture/execute/20020206-2.c: New test. From-SVN: r49550 --- gcc/ChangeLog | 6 +++++ gcc/c-common.c | 6 +++-- gcc/testsuite/ChangeLog | 2 ++ .../gcc.c-torture/execute/20020206-2.c | 24 +++++++++++++++++++ 4 files changed, 36 insertions(+), 2 deletions(-) create mode 100644 gcc/testsuite/gcc.c-torture/execute/20020206-2.c diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 86fc0629693..96baa91fc6c 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,9 @@ +2002-02-06 Jakub Jelinek + + PR c/5420: + * c-common.c (c_unsafe_for_reeval): Make COMPOUND_LITERAL_EXPR + unsafe for reevaluation. + 2002-02-06 Jakub Jelinek PR c/5482: diff --git a/gcc/c-common.c b/gcc/c-common.c index dd535ed7365..4b7946b4194 100644 --- a/gcc/c-common.c +++ b/gcc/c-common.c @@ -3567,8 +3567,10 @@ int c_unsafe_for_reeval (exp) tree exp; { - /* Statement expressions may not be reevaluated. */ - if (TREE_CODE (exp) == STMT_EXPR) + /* Statement expressions may not be reevaluated, likewise compound + literals. */ + if (TREE_CODE (exp) == STMT_EXPR + || TREE_CODE (exp) == COMPOUND_LITERAL_EXPR) return 2; /* Walk all other expressions. */ diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 8cf3dc49e2b..5c8a027d3cb 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -2,6 +2,8 @@ * gcc.c-torture/execute/20020206-1.c: New test. + * gcc.c-torture/execute/20020206-2.c: New test. + PR optimization/5429: * gcc.c-torture/compile/20020206-1.c: New test. diff --git a/gcc/testsuite/gcc.c-torture/execute/20020206-2.c b/gcc/testsuite/gcc.c-torture/execute/20020206-2.c new file mode 100644 index 00000000000..097eb3055c1 --- /dev/null +++ b/gcc/testsuite/gcc.c-torture/execute/20020206-2.c @@ -0,0 +1,24 @@ +/* Origin: PR c/5420 from David Mosberger . + This testcase was miscompiled when tail call optimizing, because a + compound literal initialization was emitted only in the tail call insn + chain, not in the normal call insn chain. */ + +typedef struct { unsigned short a; } A; + +extern void abort (void); +extern void exit (int); + +void foo (unsigned int x) +{ + if (x != 0x800 && x != 0x810) + abort (); +} + +int +main (int argc, char **argv) +{ + int i; + for (i = 0; i < 2; ++i) + foo (((A) { ((!(i >> 4) ? 8 : 64 + (i >> 4)) << 8) + (i << 4) } ).a); + exit (0); +} -- 2.30.2