From cb566e3aa895881045a4bd1fbcb5154637fb9ded Mon Sep 17 00:00:00 2001 From: Alan Modra Date: Tue, 15 Jan 2013 13:41:05 +0000 Subject: [PATCH] PR binutils/15018 * stabs.c (parse_stab_members): Always set physname here to avoid gcc warning.. (parse_stab_argtypes): ..and don't duplicate the init here. --- binutils/ChangeLog | 7 +++++++ binutils/stabs.c | 9 +++------ 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/binutils/ChangeLog b/binutils/ChangeLog index 585ed8debc0..5b8916b1b74 100644 --- a/binutils/ChangeLog +++ b/binutils/ChangeLog @@ -1,3 +1,10 @@ +2013-01-16 Alan Modra + + PR binutils/15018 + * stabs.c (parse_stab_members): Always set physname here to avoid + gcc warning.. + (parse_stab_argtypes): ..and don't duplicate the init here. + 2013-01-10 Will Newton * binutils/readelf.c: (guess_is_rela): Add EM_METAG. diff --git a/binutils/stabs.c b/binutils/stabs.c index 04c345252db..8b4597780a8 100644 --- a/binutils/stabs.c +++ b/binutils/stabs.c @@ -2758,9 +2758,8 @@ parse_stab_members (void *dhandle, struct stab_handle *info, argtypes string is the mangled form of the argument types, and the full type and the physical name must be extracted from them. */ - if (! stub) - physname = argtypes; - else + physname = argtypes; + if (stub) { debug_type class_type, return_type; @@ -2879,9 +2878,7 @@ parse_stab_argtypes (void *dhandle, struct stab_handle *info, || CONST_STRNEQ (argtypes, "__dt")); is_v3 = argtypes[0] == '_' && argtypes[1] == 'Z'; - if (is_destructor || is_full_physname_constructor || is_v3) - *pphysname = argtypes; - else + if (!(is_destructor || is_full_physname_constructor || is_v3)) { unsigned int len; const char *const_prefix; -- 2.30.2