From cb8300f5a98016ccc8d34f1bbfee9eb319a2a8a8 Mon Sep 17 00:00:00 2001 From: Tobias Droste Date: Thu, 29 Nov 2012 17:02:28 +0100 Subject: [PATCH] st/egl/drm: only unref the udev device if needed MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Fixes compiler warning: drm/native_drm.c: In function ‘native_create_display’: drm/native_drm.c:180:21: warning: ‘device’ may be used uninitialized in this function [-Wmaybe-uninitialized] drm/native_drm.c:157:24: note: ‘device’ was declared here Signed-off-by: Tobias Droste Reviewed-by: Alex Deucher --- src/gallium/state_trackers/egl/drm/native_drm.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/gallium/state_trackers/egl/drm/native_drm.c b/src/gallium/state_trackers/egl/drm/native_drm.c index 23fc137b834..f0c0f548777 100644 --- a/src/gallium/state_trackers/egl/drm/native_drm.c +++ b/src/gallium/state_trackers/egl/drm/native_drm.c @@ -161,23 +161,24 @@ drm_get_device_name(int fd) udev = udev_new(); if (fstat(fd, &buf) < 0) { _eglLog(_EGL_WARNING, "failed to stat fd %d", fd); - goto out; + goto outudev; } device = udev_device_new_from_devnum(udev, 'c', buf.st_rdev); if (device == NULL) { _eglLog(_EGL_WARNING, "could not create udev device for fd %d", fd); - goto out; + goto outdevice; } tmp = udev_device_get_devnode(device); if (!tmp) - goto out; + goto outdevice; device_name = strdup(tmp); -out: +outdevice: udev_device_unref(device); +outudev: udev_unref(udev); #endif -- 2.30.2