From cb9dbd6dec2952c894b183c860dd7520026d42ed Mon Sep 17 00:00:00 2001 From: Iago Toral Quiroga Date: Fri, 19 Jan 2018 09:17:07 +0100 Subject: [PATCH] i965/compiler: clean up nir_intrinsic_load_input for vertex shaders MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit This code to re-set the type of the source and destination is not necessary since we never manipulate the types. Looks like a left over from a time where we had to retype to float temporarily to handle 64-bit inputs. Reviewed-by: Samuel Iglesias Gonsálvez --- src/intel/compiler/brw_fs_nir.cpp | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/src/intel/compiler/brw_fs_nir.cpp b/src/intel/compiler/brw_fs_nir.cpp index 7a6346a4b5d..8efec34cc9d 100644 --- a/src/intel/compiler/brw_fs_nir.cpp +++ b/src/intel/compiler/brw_fs_nir.cpp @@ -2414,28 +2414,19 @@ fs_visitor::nir_emit_vs_intrinsic(const fs_builder &bld, fs_reg src = fs_reg(ATTR, nir_intrinsic_base(instr) * 4, dest.type); unsigned first_component = nir_intrinsic_component(instr); unsigned num_components = instr->num_components; - enum brw_reg_type type = dest.type; nir_const_value *const_offset = nir_src_as_const_value(instr->src[0]); assert(const_offset && "Indirect input loads not allowed"); src = offset(src, bld, const_offset->u32[0]); - if (type_sz(type) == 8) + if (type_sz(dest.type) == 8) first_component /= 2; for (unsigned j = 0; j < num_components; j++) { bld.MOV(offset(dest, bld, j), offset(src, bld, j + first_component)); } - if (type == BRW_REGISTER_TYPE_DF) { - /* Once the double vector is read, set again its original register - * type to continue with normal execution. - */ - src = retype(src, type); - dest = retype(dest, type); - } - - if (type_sz(src.type) == 8) { + if (type_sz(dest.type) == 8) { shuffle_32bit_load_result_to_64bit_data(bld, dest, retype(dest, BRW_REGISTER_TYPE_F), -- 2.30.2