From cbbdbcbd6850fa7da83f0def9b6f113ec41da0c0 Mon Sep 17 00:00:00 2001 From: Tony Gutierrez Date: Thu, 25 Oct 2018 12:56:20 -0400 Subject: [PATCH] misc: Update workflow requirements in CONTRIBUTING.md Change-Id: I5394ef58930fccea343414964c1fc3e18829d609 Reviewed-on: https://gem5-review.googlesource.com/c/13755 Reviewed-by: Jason Lowe-Power Reviewed-by: Nikos Nikoleris Reviewed-by: Daniel Carvalho Reviewed-by: Andreas Sandberg Maintainer: Jason Lowe-Power --- CONTRIBUTING.md | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 2ceded164..465d604f8 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -77,6 +77,19 @@ submit your code to the mainline of gem5, the code is reviewed by others in the community. Additionally, the maintainer for that part of the code must sign off on it. +Contributing long-lived feature branches +---------------------------------------- +Oftentimes users or institutions add features that are necessarily complex, +and require many changes on long-lived feature branches. In this case, +maintaining a perfect history where all changes work individually is infeasible. +When contributing long-lived feature branches back to gem5's public repository +users may merge entire long-lived branches into a single changeset and contribute +their code back as long as 1) the changes have been reviewed by the maintainer +2) the maintainer agrees to allow such a change, and 3) the changes are passing +the public tests. Changes that affect common code (outside of a specific +maintainer's purview) will still need to follow the standard gem5 protocol. + + Cloning the gem5 repo to contribute =================================== -- 2.30.2