From cbe54154ef7b3915c5ef2c20bddf78463ed6b566 Mon Sep 17 00:00:00 2001 From: Pedro Alves Date: Tue, 12 May 2009 16:51:13 +0000 Subject: [PATCH] gdb/ 2009-05-12 Pedro Alves * cli/cli-decode.c (deprecated_add_set_cmd): Delete. * command.h (deprecated_add_set_cmd): Delete declaration. * gnu-nat.c (_initialize_gnu_nat): Replace 'maint gnu-debug' with 'set debug gnu-nat' and 'show debug gnu-nat'. * i386-nat.c (_initialize_i386_nat): Replace 'maint show-debug-registers' with 'maint set show-debug-registers' and 'maint show show-debug-registers'. * mips-linux-nat.c (_initialize_mips_linux_nat): Replace 'maint show-debug-registers' with 'maint set show-debug-registers' and 'maint show show-debug-registers'. gdb/doc/ 2009-05-12 Pedro Alves * gdb.texinfo: Document 'set/show debug gnu-nat'. Replace 'maint show-debug-regs' docs by 'maint set show-debug-regs' and 'maint show show-debug-regs' docs. --- gdb/ChangeLog | 13 +++++++++++++ gdb/cli/cli-decode.c | 11 ----------- gdb/command.h | 10 ---------- gdb/doc/ChangeLog | 6 ++++++ gdb/doc/gdb.texinfo | 11 +++++++++-- gdb/gnu-nat.c | 13 +++++++++---- gdb/i386-nat.c | 12 ++++++++---- gdb/mips-linux-nat.c | 13 ++++++++----- 8 files changed, 53 insertions(+), 36 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 37806326d4a..c334f58233d 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,16 @@ +2009-05-12 Pedro Alves + + * cli/cli-decode.c (deprecated_add_set_cmd): Delete. + * command.h (deprecated_add_set_cmd): Delete declaration. + * gnu-nat.c (_initialize_gnu_nat): Replace 'maint gnu-debug' with + 'set debug gnu-nat' and 'show debug gnu-nat'. + * i386-nat.c (_initialize_i386_nat): Replace 'maint + show-debug-registers' with 'maint set show-debug-registers' and + 'maint show show-debug-registers'. + * mips-linux-nat.c (_initialize_mips_linux_nat): Replace 'maint + show-debug-registers' with 'maint set show-debug-registers' and + 'maint show show-debug-registers'. + 2009-05-12 Joel Brobecker * c-lang.c (print_wchar): Convert w into a gdb_wchar_t before diff --git a/gdb/cli/cli-decode.c b/gdb/cli/cli-decode.c index 4ebf6dc6194..db7789f796a 100644 --- a/gdb/cli/cli-decode.c +++ b/gdb/cli/cli-decode.c @@ -397,17 +397,6 @@ add_setshow_cmd_full (char *name, *show_result = show; } -struct cmd_list_element * -deprecated_add_set_cmd (char *name, - enum command_class class, - var_types var_type, - void *var, - char *doc, - struct cmd_list_element **list) -{ - return add_set_or_show_cmd (name, set_cmd, class, var_type, var, doc, list); -} - /* Add element named NAME to command list LIST (the list for set or some sublist thereof). CLASS is as in add_cmd. ENUMLIST is a list of strings which may follow NAME. VAR is address of the variable diff --git a/gdb/command.h b/gdb/command.h index bed615c31af..1a6bec417fa 100644 --- a/gdb/command.h +++ b/gdb/command.h @@ -205,16 +205,6 @@ extern void help_list (struct cmd_list_element *, char *, extern void help_cmd_list (struct cmd_list_element *, enum command_class, char *, int, struct ui_file *); -/* NOTE: cagney/2005-02-21: Since every set command should be paired - with a corresponding show command (i.e., add_setshow_*) this call - should not be needed. Unfortunatly some are not (e.g., - "maintenance ") and those need to be fixed. */ -extern struct cmd_list_element *deprecated_add_set_cmd (char *name, enum - command_class class, - var_types var_type, void *var, - char *doc, - struct cmd_list_element **list); - /* Method for show a set/show variable's VALUE on FILE. If this method isn't supplied deprecated_show_value_hack() is called (which is not good). */ diff --git a/gdb/doc/ChangeLog b/gdb/doc/ChangeLog index 88ec627916a..7885a701384 100644 --- a/gdb/doc/ChangeLog +++ b/gdb/doc/ChangeLog @@ -1,3 +1,9 @@ +2009-05-12 Pedro Alves + + * gdb.texinfo: Document 'set/show debug gnu-nat'. Replace 'maint + show-debug-regs' docs by 'maint set show-debug-regs' and 'maint + show show-debug-regs' docs. + 2009-05-08 Eli Zaretskii * gdb.texinfo (Process Record and Replay): Add description of diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo index 4f5b65994d4..f1b892de7b0 100644 --- a/gdb/doc/gdb.texinfo +++ b/gdb/doc/gdb.texinfo @@ -17829,6 +17829,11 @@ default is off. @item show debug frame Displays the current state of displaying @value{GDBN} frame debugging info. +@item set debug gnu-nat +@cindex @sc{gnu}/Hurd debug messages +Turns on or off debugging messages from the @sc{gnu}/Hurd debug support. +@item show debug gnu-nat +Show the current state of @sc{gnu}/Hurd debugging messages. @item set debug infrun @cindex inferior debugging info Turns on or off display of @value{GDBN} debugging info for running the inferior. @@ -25947,9 +25952,11 @@ data in a @file{gmon.out} file, be sure to move it to a safe location. Configuring with @samp{--enable-profiling} arranges for @value{GDBN} to be compiled with the @samp{-pg} compiler option. -@kindex maint show-debug-regs +@kindex maint set show-debug-regs +@kindex maint show show-debug-regs @cindex hardware debug registers -@item maint show-debug-regs +@item maint set show-debug-regs +@itemx maint show show-debug-regs Control whether to show variables that mirror the hardware debug registers. Use @code{ON} to enable, @code{OFF} to disable. If enabled, the debug registers values are shown when @value{GDBN} inserts or diff --git a/gdb/gnu-nat.c b/gdb/gnu-nat.c index 157c95061ec..b3b89a40a63 100644 --- a/gdb/gnu-nat.c +++ b/gdb/gnu-nat.c @@ -3410,10 +3410,15 @@ _initialize_gnu_nat (void) add_task_commands (); add_thread_commands (); - deprecated_add_set_cmd ("gnu-debug", class_maintenance, - var_boolean, (char *) &gnu_debug_flag, - "Set debugging output for the gnu backend.", - &maintenancelist); + add_setshow_boolean_cmd ("gnu-nat", class_maintenance, + &gnu_debug_flag, + _("Set debugging output for the gnu backend."), + _("Show debugging output for the gnu backend."), + NULL, + NULL, + NULL, + &setdebuglist, + &showdebuglist); } #ifdef FLUSH_INFERIOR_CACHE diff --git a/gdb/i386-nat.c b/gdb/i386-nat.c index 667a5755861..f7cf112738b 100644 --- a/gdb/i386-nat.c +++ b/gdb/i386-nat.c @@ -700,13 +700,17 @@ _initialize_i386_nat (void) #ifdef I386_USE_GENERIC_WATCHPOINTS /* A maintenance command to enable printing the internal DRi mirror variables. */ - deprecated_add_set_cmd ("show-debug-regs", class_maintenance, - var_boolean, (char *) &maint_show_dr, _("\ -Set whether to show variables that mirror the x86 debug registers.\n\ + add_setshow_boolean_cmd ("show-debug-regs", class_maintenance, + &maint_show_dr, _("\ +Set whether to show variables that mirror the x86 debug registers."), _("\ +Show whether to show variables that mirror the x86 debug registers."), _("\ Use \"on\" to enable, \"off\" to disable.\n\ If enabled, the debug registers values are shown when GDB inserts\n\ or removes a hardware breakpoint or watchpoint, and when the inferior\n\ triggers a breakpoint or watchpoint."), - &maintenancelist); + NULL, + NULL, + &maintenance_set_cmdlist, + &maintenance_show_cmdlist); #endif } diff --git a/gdb/mips-linux-nat.c b/gdb/mips-linux-nat.c index ac8d96daac4..ca7c03d4ff6 100644 --- a/gdb/mips-linux-nat.c +++ b/gdb/mips-linux-nat.c @@ -1044,15 +1044,18 @@ _initialize_mips_linux_nat (void) { struct target_ops *t; - deprecated_add_set_cmd ("show-debug-regs", class_maintenance, - var_boolean, (char *) &maint_show_dr, _("\ -Set whether to show variables that mirror the mips debug registers.\n\ + add_setshow_boolean_cmd ("show-debug-regs", class_maintenance, + &maint_show_dr, _("\ +Set whether to show variables that mirror the mips debug registers."), _("\ +Show whether to show variables that mirror the mips debug registers."), _("\ Use \"on\" to enable, \"off\" to disable.\n\ If enabled, the debug registers values are shown when GDB inserts\n\ or removes a hardware breakpoint or watchpoint, and when the inferior\n\ triggers a breakpoint or watchpoint."), - &maintenancelist); - + NULL, + NULL, + &maintenance_set_cmdlist, + &maintenance_show_cmdlist); t = linux_trad_target (mips_linux_register_u_offset); -- 2.30.2