From cc1e0483ae354533c559a3b542351f0024e5ba41 Mon Sep 17 00:00:00 2001 From: Tom de Vries Date: Tue, 12 May 2015 16:23:38 +0000 Subject: [PATCH] check_GNU_style.sh: Fix tab size in 80 characters check 2015-05-12 Tom de Vries * check_GNU_style.sh (col): Fix tab size. From-SVN: r223088 --- contrib/ChangeLog | 4 ++++ contrib/check_GNU_style.sh | 38 +++++++++++++++++++++++++++++++------- 2 files changed, 35 insertions(+), 7 deletions(-) diff --git a/contrib/ChangeLog b/contrib/ChangeLog index 97941f77f00..e9768a21a10 100644 --- a/contrib/ChangeLog +++ b/contrib/ChangeLog @@ -1,3 +1,7 @@ +2015-05-12 Tom de Vries + + * check_GNU_style.sh (col): Fix tab size. + 2015-05-12 Tom de Vries * check_GNU_style.sh: Put stdin into a temp file. diff --git a/contrib/check_GNU_style.sh b/contrib/check_GNU_style.sh index 318eb6adca5..90c612ff1cb 100755 --- a/contrib/check_GNU_style.sh +++ b/contrib/check_GNU_style.sh @@ -116,13 +116,37 @@ vg (){ col (){ msg="$1" - cat $inp \ - | awk -F':\\+' '{ if (length($2) > 80) print $0}' \ - > $tmp - if [ -s $tmp ]; then - printf "\n$msg\n" - cat $tmp - fi + local first=true + local f + for f in $files; do + local prefix="" + if [ $nfiles -ne 1 ]; then + prefix="$f:" + fi + + # Don't reuse $inp, which may be generated using -H and thus contain a + # file prefix. + grep -n '^+' $f \ + | grep -v ':+++' \ + > $tmp + + cat $tmp | while IFS= read -r line; do + local longline + # Filter out the line number prefix and the patch line modifier '+' + # to obtain the bare line, before we use expand. + longline=$(echo "$line" \ + | sed 's/^[0-9]*:+//' \ + | expand \ + | awk '{ if (length($0) > 80) print $0}') + if [ "$longline" != "" ]; then + if $first; then + printf "\n$msg\n" + first=false + fi + echo "$prefix$line" + fi + done + done } col 'Lines should not exceed 80 characters.' -- 2.30.2